1209175 - Fix a conditional statement in msgMapiHook.cpp

Status: RESOLVED FIXED

(MailNews Core :: Simple MAPI, defect)

Description

[Stefan Sitter [:ssitter]]

From http://www.viva64.com/en/b/0347/

PVS-Studio's diagnostic message: V523 The 'then' statement is equivalent to the 'else' statement. mailnews/mapi/mapihook/src/msgMapiHook.cpp 677

  if (aFlags & MAPI_UNICODE)
  {
    if (aDelimChar)
      strDelimChars.Assign (aDelimChar);
    if (aFilePaths)
      strFilePaths.Assign (aFilePaths);
  }
  else
  {
    if (aDelimChar)
      strDelimChars.Assign(aDelimChar);
    if (aFilePaths)
      strFilePaths.Assign ( aFilePaths);
  }

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: Remove unnecessary conditional statement in msgMapiHook.cpp

Comment 2

[Kent James (:rkent)]

Comment on attachment 8666865 [details] [diff] [review]
Remove unnecessary conditional statement in msgMapiHook.cpp

Review of attachment 8666865 [details] [diff] [review]:
-----------------------------------------------------------------

Checking the CVS history at https://github.com/ehsan/mozilla-cvs-history/commit/cdd0eeaddeb53a9895ccaeb4f8b36b6c5728cdc2 this came about originally because new string classes were added, and the previous version needed separate string calls. So this is a valid change.

Comment 3

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/716926aa9ec7dffba78e8433c5389d8cea50685d
Bug 1209175 - Fix a conditional statement in msgMapiHook.cpp. r=rkent