1209256 - [Music][NGA] Break up locale '.properties' file per-view

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Justin D'Arcangelo [:justindarc]]

As part of NGA, localization '.properties' files are to be broken up to be one-per-view. This is to prevent every view from having to load the full set of l10n strings.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Re-assigning to stas who volunteered :-)

Comment 2

[Staś Małolepszy :stas]

Thanks.  Pasting relevant bits from our chat on IRC:

19:43 <stas> justindarc: do you need help with https://bugzilla.mozilla.org/show_bug.cgi?id=1209256 ?
19:43 <justindarc> stas: if you'd like :-)
19:44 <justindarc> stas: i haven't started yet
19:44 <stas> that's one of the selling points of the new architecture of l20n:  to be able to this, so I'm really curious to see if it improves perf
19:44 <stas> we could first try to land the client/service bug,and then I'll be happy to help with splitting the resources
19:45 <justindarc> stas: ok cool.. just double-check the custom elements used in each view for l10n strings too
19:45 <justindarc> stas: there shouldn't be many in the web components, but you never know
19:45 <justindarc> stas: in the player view, you may have a few (because of the aria-label attrs on the music player elements)
19:45 <stas> right now, music.properties is loaded once in index.html, and cached in the service. if index.html and home are small l10n-wise, we might end up loading smaller translation files
19:46 <stas> and if the user never navigates to some views, we'd be saving memory too
19:46 <stas> that's the plan at least
19:46 <justindarc> stas: yeah, they will only be 2-3 strings in most views
19:48 <justindarc> stas: pretty much the only strings needed on any of the "list" views are "Unknown album", "Unknown artist", "Search", "close" and "No music found"
19:48 <justindarc> so.. 5 strings i guess
19:48 <stas> are there strings related to the scanning progress?
19:49 <stas> music.properties is rather tiny, weghing in at 2k, so we might not see a difference with split resources
19:49 <stas> I still want to try this though
19:50 <justindarc> stas: most strings are in the parent window that contains the sub-views
19:50 <justindarc> stas: so like the tab bar, music scanning, overlay dialogs, etc.

Comment 3

[Staś Małolepszy :stas]

flod, what's your take on this bug?  I know this would create some noise for the localizers because of the strings being moved across files.  OTOH, I'd love to experiment with this spit-file approach now and start recommending it for new NGA apps.

Comment 4

[Francesco Lodolo [:flod]]

Some concerns, not sure if they're due to a misinterpretation on my side:
* We might end up duplicating a lot of strings. For example, you have a "Cancel" button label that you need in multiple views for the same app. Either you add the same string to each file, or you create a shared .properties file, and we're kind of back to step 1.
* So far I don't have a great experience with Gaia and splitting strings up (Communications).

I'd also like to see some data on the approach, to figure out if it's worth the noise we create for localizers.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] stasm:1209256-split-l10n-resources-per-view > mozilla-b2g:master

Comment 6

[Staś Małolepszy :stas]

Music only has a handful of strings so I'm not seeing any performance changes with this pr.

music.gaiamobile.org   base: mean  1: mean  1: delta  1: p-value
---------------------  ----------  -------  --------  ----------
navigationLoaded              312      310        -1        0.83
navigationInteractive         325      325        -1        0.94
visuallyLoaded                714      712        -2        0.82
contentInteractive            714      712        -3        0.81
fullyLoaded                   941      951        10        0.44
uss                        15.624   15.605    -0.019        0.73
pss                        20.076   20.071    -0.005        0.92
rss                        35.294   35.278    -0.016        0.76

Comment 7

[Staś Małolepszy :stas]

The following strings were no longer used anywhere so I removed them:

unknown = ?
search-music.placeholder = Search Music
search-cancel = Cancel
search-artists = Artists
search-albums = Albums
search-titles = Tracks
saved = Saved {{title}} to Music
audioinvalid = Audio cannot be played: format is unsupported or file is invalid.
music-paused-notification = Music paused during the call
player-album-rating.ariaLabel = Rating

Comment 8

[BMO Automation]

Firefox OS is not being worked on