120931 - win32: Mozilla does not remember the last directory used to load

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Dan Tobias]

This should be thought of as a "sister bug" to bug 115148, recently fixed, in
which Mozilla formerly failed to be "smart" about remembering what directory
you're saving files to.

That's fixed now, but the behavior in *loading* files (in the "Open File..."
menu item, in the file pick dialog for form submissions, etc.) still remains in
the old, annoying behavior of always using the system default no matter where
you've actually been getting files from recently.  This can be a big nuisance
when you're trying to open or upload a large number of files from the same
place.  (Perhaps both this and bug 115148 should be considered different aspects
of bug 27493, either as dupes of it or dependencies of it.)

Comment 1

[Andrew Hagen]

Confirming on Windows 98, 0.9.7, Build ID: 2002011803.

Comment 2

[sairuh (rarely reading bugmail)]

hm, i think this would be a dup of 27493... if not, could you pls clarify why?

*** This bug has been marked as a duplicate of 27493 ***

Comment 3

[Dan Tobias]

If this is a dupe, why wasn't bug 115148 a dupe as well?  That one dealt
specifically with the save directory, while this one deals directly with the
load directory, but bug 27493 deals with both.  Apparently the save directory
status was regarded as a separate issue, because that was fixed while load
directories weren't.

Comment 4

[Boris Zbarsky [:bzbarsky]]

The save directory used to be remembered, thus bug 115148 was a regression.....

Comment 5

[Bill Law]

Attachment: Patch to maintain copy of last used directory.

This patch keeps a copy of the last-used directory and starts the file-picker
there unless another directory is specified via the "displayDirectory"
attribute.

I've tested this patch on Win2000, but the bug doesn't manifest itself there
(Win2K remembers the last-used directory for us).  Can somebody with Win98
apply the patch and try it there?

We need this bug, distinct from bug 27943, because that bug is one of those
utopian, grandiose things that will never be implemented (no offense).	This
problem is due to a fix I made a while back to stop us from resetting the
current directory to the one last used via the file picker (which was *not* the
way to implement this feature).
P.S. This also fixes a problem with the mSelectedType field where it isn't
being initialized properly.

Comment 6

[Bill Law]

reopening; see my previous comment

Comment 7

[Bill Law]

Attachment: revised patch

I removed some debugging stuff and added code to update mDisplayDirectory with
the last-used directory.  Charley Manske alerted me that Composer is dependent
on that.

Comment 8

[Charles Manske]

Comment on attachment 66204 [details] [diff] [review]
revised patch

r=cmanske
great! works for me.
It turns out Composer is not dependent on this,
but I think setting mDisplayDirectory is a good thing.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 66204 [details] [diff] [review]
revised patch

sr=[e-mail]

Comment 10

[Bill Law]

fixed

Comment 11

[sairuh (rarely reading bugmail)]

vrfy...has been fine for some time. :)