1209349 - Audit the callers of the two-argument OriginAttributes constructor

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bobby Holley (:bholley)]

Looking through the code, I see a lot of callers that follow the letter of OriginAttributes but not the spirit:

https://dxr.mozilla.org/mozilla-central/rev/6256ec9113c115141aab089c45ee69438884b680/dom/quota/QuotaManager.cpp#5291

Stuff like that isn't going to work when we add signedPkg etc. We should audit and fix these consumers, and possibly remove that constructor.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b08d94df2937

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8699420 [details] [diff] [review]
Patch.

Review of attachment 8699420 [details] [diff] [review]:
-----------------------------------------------------------------

Hi, Janv
Could you help to review QuotaManager part for me?
I only updated OriginProps and some code in OriginParser.

Thanks

Comment 4

[Jan Varga [:janv]]

Comment on attachment 8699420 [details] [diff] [review]
Patch.

Review of attachment 8699420 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you address my comments

::: dom/quota/ActorsParent.cpp
@@ +5988,5 @@
>      nsCString spec;
> +    PrincipalOriginAttributes attrs;
> +    bool result = OriginParser::ParseOrigin(NS_ConvertUTF16toUTF8(leafName),
> +                                            spec, &attrs);
> +    NS_ENSURE_TRUE(result, NS_ERROR_FAILURE);

please don't use NS_ENSURE_TRUE(), see my comment below

@@ +6170,5 @@
>          }
>  
> +        nsCOMPtr<nsIPrincipal> principal =
> +          BasePrincipal::CreateCodebasePrincipal(uri, originProps.mAttrs);
> +        NS_ENSURE_TRUE(principal, NS_ERROR_FAILURE);

please no more NS_ENSURE_TRUE(), use this instead:

if (NS_WARN_IF(!principal)) {
  return NS_ERROR_FAILURE;
}

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba6ecf578741

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2

addressed janv's comment.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/63254aa6dfabeced552c9401cf9fb3cfa9b7add4
Bug 1209349 - Audit the callers of the two-argument OriginAttributes. r=janv

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/63254aa6dfab