1209376 - Update verification/update_verify from 41.0b1 fails on linux

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Rail Aliiev [:rail]]

../../update/updater: error while loading shared libraries: libmozsqlite3.so: cannot open shared object file: No such file or directory

The updater binary cannot be executed from command line anymore. :/

It works as expected in 41.0b9.

Could be related to bug 1158870

Comment 1

[Rail Aliiev [:rail]]

I disabled all updates on the beta channel for now.

Comment 2

[Rail Aliiev [:rail]]

$ LD_LIBRARY_PATH=. ./updater
Usage: updater patch-dir install-dir apply-to-dir [wait-pid [callback-working-dir callback-path args...]]

Sounds like a linking issue.

Comment 3

[Rail Aliiev [:rail]]

I tried to update 41.0b1 to 41.0b2 using the UI (beta-localtest) and it worked as expected an updated me to 41.0b2.

Comment 4

[Rail Aliiev [:rail]]

Attachment: LD_LIBRARY_PATH_linux.diff

This worked on my laptop,

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8667256 [details] [diff] [review]
LD_LIBRARY_PATH_linux.diff

remote:   https://hg.mozilla.org/build/tools/rev/2a2e270f5f92
remote:   https://hg.mozilla.org/build/tools/rev/e706b6486661

Comment 6

[Rail Aliiev [:rail]]

Fixed tags https://hg.mozilla.org/build/tools/rev/6bc4736018af

Comment 7

[Rail Aliiev [:rail]]

Now it's failing because of missing libgtk-3.so:

../../update/updater: error while loading shared libraries: libgtk-3.so.0: cannot open shared object file: No such file or directory

Probably we should use tooltool to get it...

Comment 8

[Rail Aliiev [:rail]]

glandium,

Maybe you have some ideas here. Can we link the updater so it doesn't require GTK?

Comment 9

[Mike Hommey [:glandium]]

(In reply to Rail Aliiev [:rail] from comment #8)
> glandium,
> 
> Maybe you have some ideas here. Can we link the updater so it doesn't
> require GTK?

Considering https://dxr.mozilla.org/mozilla-central/rev/acdb22976ff86539dc10413c5f366e1fb429a680/toolkit/mozapps/update/updater/updater-common.build?offset=0#71 , no.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Hit this for Thunderbird 42.0b1 -> 42.0b2 too.

Comment 11

[Rail Aliiev [:rail]]

Not working on this actively

Comment 12

[Wayne Mery (:wsmwk)]

update_verify_beta for linux64 also happend for 43 and 44 beta

Comment 13

[[e-mail] (:bhearsum)]

Does this mean that update verify is essentially broken for Firefox 44.0 (and up) on Linux? If so, this is pretty serious, because it means we're getting zero validation of partial updates.

Comment 14

[Rail Aliiev [:rail]]

ATM the only GTK3 enabled build is 41.0b1, we disabled it in later versions.

When we try to run update verify with $from == 41.0b1 we get these failures, otherwise it works.

But I agree, that this is serious and we should fix this.

Comment 15

[Justin Wood (:Callek)]

for what its worth, release-promotion update verify fixes it.... Its not exactly easy to fix on buildbot infra...

Comment 16

[Rail Aliiev [:rail]]

WFM now!