1209430 - [Music NGA]The "Shuffle all" icon is not shown as highlighted after tapping "Shuffle all" on Playlists tab.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Shally Li（leave from Mozilla）]

[1.Description]:
[Flame][Music NGA]Disabling "Shuffle all" to make it shown as grey and then tapping "Shuffle all" on Playlists tab, the "Shuffle all" icon is not shown as highlighted.

Found at: 20:24
Attach: logcat_2024.txt and Flame_v2.5.3gp.

[2.Testing Steps]: 
Prerequisite: There are some songs in device and disable "Shuffle all".

1. Launch the NGA Music app. 
2. Switch to Playlists tab. 
3. Select "Shuffle all".


[3.Expected Result]: 
3. The "Shuffle all" icon should show as highlighted after tapping "Shuffle all" on Playlists tab.

[4.Actual Result]: 
3. The "Shuffle all" icon is not shown as highlighted.

[5.Reproduction build]: 
Device: Flame KK 2.5 (affected)
Build ID               20150928150204
Gaia Revision          01ffe82cf088ca8fda9fe6783dc5cad2c3dde01c
Gaia Date              2015-09-28 08:49:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/031db40e2b558c7e4dd0b4c565db4a992c1627c8
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150928.182514
Firmware Date          Mon Sep 28 18:25:26 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free test

[8.Note]:
It will be shown as highlighted after tapping "Shuffle all" on Playlists tab in OGA music app.

Comment 1

[Shally Li（leave from Mozilla）]

Attachment: logcat_2024.txt

Comment 2

[Shally Li（leave from Mozilla）]

Attachment: Flame_v2.5.3gp

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] justindarc:bug1209430 > mozilla-b2g:master

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8670892 [details] [review]
[gaia] justindarc:bug1209430 > mozilla-b2g:master

Got rid of the separate getters for the repeat/shuffle settings so the Player view only has to make a single API call to the backend to get "playback status" which now contains those values. We already get updated "playback status" anytime the song changes so this also addresses the problem in this bug while being more efficient.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/1bf27d79ac5da023feebc8cf2389b15123398a4f

Comment 6

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: The "Shuffle all" icon will be shown as highlighted after tapping "Shuffle all" on Playlists tab.
See attachment: verified_NGA_Music_Aires_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20151009150221
Gaia Revision          1609aecaba381c14eff95d5084e59280f53b7d8b
Gaia Date              2015-10-09 07:16:19
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c00e93135684441d065791f4f98a338b872d0420
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151009.183801
Firmware Date          Fri Oct  9 18:38:15 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151010002512
Gaia Revision          74b0d4b17f39d238a7997800bd9363d3c60f20c3
Gaia Date              2015-10-09 19:27:39
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1bb0de19476541cd517ab14017e7fedbd9f13e3
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151009.234251
Firmware Date          Fri Oct  9 23:42:59 UTC 2015
Bootloader             s1

Comment 7

[Shally Li（leave from Mozilla）]

Attachment: verified_NGA_Music_Aires_v2.5.3gp