1209435 - [Coverity 1123223] Leak of memory or pointers to system resources in NSC_SignInit

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Two occurrences:

> case CKM_NSS_HMAC_CONSTANT_TIME: {
>   sftk_MACConstantTimeCtx *ctx =
>       sftk_HMACConstantTime_New(pMechanism,key);
>   CK_ULONG *intpointer;
>   
>   if (ctx == NULL) {
>       crv = CKR_ARGUMENTS_BAD;
>       break;
>   }
>   intpointer = PORT_New(CK_ULONG);
>   if (intpointer == NULL) {
>       crv = CKR_HOST_MEMORY;
>       break;
>   }

> case CKM_NSS_SSL3_MAC_CONSTANT_TIME: {
>   sftk_MACConstantTimeCtx *ctx =
>       sftk_SSLv3MACConstantTime_New(pMechanism,key);
>   CK_ULONG *intpointer;
>   
>   if (ctx == NULL) {
>       crv = CKR_ARGUMENTS_BAD;
>       break;
>   }
>   intpointer = PORT_New(CK_ULONG);
>   if (intpointer == NULL) {
>       crv = CKR_HOST_MEMORY;
>       break;
>   }

3. alloc_fn: Storage is returned from allocation function sftk_SSLv3MACConstantTime_New.

4. var_assign: Assigning: ctx = storage returned from sftk_SSLv3MACConstantTime_New(pMechanism, key).

8. leaked_storage: Variable ctx going out of scope leaks the storage it points to.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Patch at: https://codereview.appspot.com/265320043

Comment 2

[Eric Rescorla (:ekr)]

LGTM

Comment 3

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/924c6ad4a9c1