1209490 - (Gaia RTL 2.5) CSS refactoring: gaia_menu

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Shared, defect)

Description

[Augustin Trancart [:autra]]

CSS refactoring of the <gaia-menu> web component.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1209490-wc-gaia_menu_rtl > mozilla-b2g:master

Comment 2

[Augustin Trancart [:autra]]

Comment on attachment 8668331 [details] [review]
[gaia] Phoxygen:bug1209490-wc-gaia_menu_rtl > mozilla-b2g:master

Hi Kevin! 

Here is the refacto of gaia-menu for RTL. Please r?

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8668331 [details] [review]
[gaia] Phoxygen:bug1209490-wc-gaia_menu_rtl > mozilla-b2g:master

This seems to break the cancel button in the index.html example at the bottom of the menu. Can you please take a look and re-flag me when ready?

Comment 4

[Augustin Trancart [:autra]]

Are you speaking about https://bugzilla.mozilla.org/show_bug.cgi?id=1196268 or is it something else?

Comment 5

[Kevin Grandon :kgrandon]

Augustin - Bug 1196268 is now fixed, could you please rebase this against master and ensure that the button rendering continues to work properly? I believe the symptom of the back button that I saw was slightly different than the above patch, but rebasing should work.

Please open for review again once rebased. Thanks!

Comment 6

[Augustin Trancart [:autra]]

Comment on attachment 8668331 [details] [review]
[gaia] Phoxygen:bug1209490-wc-gaia_menu_rtl > mozilla-b2g:master

Done!

The cancel button seems fine to me now (and I'm happy you got this fixed, because that was really bad to use on a daily basis). Please r again!

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8668331 [details] [review]
[gaia] Phoxygen:bug1209490-wc-gaia_menu_rtl > mozilla-b2g:master

This looks good to me. Thank you!

Comment 8

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/96c311159088280561b42e7fd2980b05b55d5835