1209523 - Grunt build failing with 'Parse Error'

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Ed Morley [:emorley]]

[~/src/treeherder]$ grunt build
Running "clean:dist" (clean) task
>> 1 path cleaned.

Running "copy:main" (copy) task
Copied 5 files

Running "copy:img" (copy) task
Copied 10 files

Running "copy:fonts" (copy) task
Copied 11 files

Running "useminPrepare:index" (useminPrepare) task
Configuration changed for concat, uglify, cssmin

Running "useminPrepare:userguide" (useminPrepare) task
Configuration changed for concat, uglify, cssmin

Running "useminPrepare:logviewer" (useminPrepare) task
Configuration changed for concat, uglify, cssmin

Running "useminPrepare:perf" (useminPrepare) task
Configuration changed for concat, uglify, cssmin

Running "concat:generated" (concat) task
File .tmp\concat\css\index.min.css created.
File .tmp\concat\js\index.min.js created.
File .tmp\concat\css\userguide.min.css created.
File .tmp\concat\css\logviewer.min.css created.
File .tmp\concat\js\logviewer.min.js created.
File .tmp\concat\css\perf.min.css created.
File .tmp\concat\js\perf.min.js created.

Running "cssmin:generated" (cssmin) task
>> 4 files created. 809.14 kB → 648.16 kB

Running "uglify:generated" (uglify) task
>> 3 files created.

Running "usemin:html" (usemin) task
Replaced 4 references to assets

Running "ngtemplates:treeherder" (ngtemplates) task
Warning: Parse Error: <span class="fa fa-times lightgray"</span>

...

 Use --force to continue.

Aborted due to warnings.

Comment 1

[Ed Morley [:emorley]]

Also the new JS isn't minified.

Comment 2

[Ed Morley [:emorley]]

Attachment: Fix grunt build of userguide.html

Comment 3

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5065de4588696c3de4958ff552d0eebfd563de5a
Bug 1209523 - Fix parse error during grunt build

As part of my work to get grunt build running automatically on deploy,
I'm going to run it on Travis to make sure we catch things like this
before deploy :-)

https://github.com/mozilla/treeherder/commit/a76a06b850dc1d1199e1a6e1fd4949f76c660dc0
Bug 1209523 - Fix grunt build minification of userguide.html

Also the s/userguide.app/userguide/ was to fix:

Error: [$injector:nomod] Module 'userguide' is not available!