Closed
Bug 120953
Opened 24 years ago
Closed 24 years ago
pldhash ignores alpha bounds for removes during enumeration
Categories
(Core :: XPCOM, defect, P1)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.0
People
(Reporter: dbaron, Assigned: brendan)
Details
Attachments
(1 file)
|
2.82 KB,
patch
|
dbaron
:
review+
shaver
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
PL_DHashTableEnumerate doesn't consider the alpha bounds in the latter part of
the function where it shrinks the table if enough entries were removed. It
probably should, although I'm not completely sure how. (Perhaps it should work
just like the PL_DHASH_REMOVE op does?) I wonder if the code for the
PL_DHASH_ADD op should consider the minimum as well (where it looks at the
removedCount). I haven't thought this through completely, though.
|
Assignee | |
Updated•24 years ago
|
|
|
Assignee | |
Comment 1•24 years ago
|
||
I'd like to fix this for 1.0, for API purity of essence.
/be
Keywords: mozilla0.9.9 → mozilla1.0
Target Milestone: mozilla0.9.9 → mozilla1.0
|
|
Assignee | |
Comment 2•24 years ago
|
||
|
||
Comment 3•24 years ago
|
||
Comment on attachment 73504 [details] [diff] [review]
proposed fix, includes fix for bug 128861
sr=shaver.
Attachment #73504 -
Flags: superreview+
|
Reporter | |
Comment 4•24 years ago
|
||
Comment on attachment 73504 [details] [diff] [review]
proposed fix, includes fix for bug 128861
r=dbaron
Attachment #73504 -
Flags: review+
|
|
Assignee | |
Updated•24 years ago
|
Priority: P2 → P1
|
||
Comment 5•24 years ago
|
||
Comment on attachment 73504 [details] [diff] [review]
proposed fix, includes fix for bug 128861
a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #73504 -
Flags: approval+
|
|
Assignee | |
Comment 6•24 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•