pldhash ignores alpha bounds for removes during enumeration

RESOLVED FIXED in mozilla1.0

Status

()

Core
XPCOM
P1
normal
RESOLVED FIXED
17 years ago
16 years ago

People

(Reporter: dbaron, Assigned: brendan)

Tracking

Trunk
mozilla1.0
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
PL_DHashTableEnumerate doesn't consider the alpha bounds in the latter part of
the function where it shrinks the table if enough entries were removed.  It
probably should, although I'm not completely sure how.  (Perhaps it should work
just like the PL_DHASH_REMOVE op does?)  I wonder if the code for the
PL_DHASH_ADD op should consider the minimum as well (where it looks at the
removedCount).  I haven't thought this through completely, though.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Keywords: mozilla0.9.9
Priority: -- → P2
Target Milestone: --- → mozilla0.9.9
(Assignee)

Comment 1

17 years ago
I'd like to fix this for 1.0, for API purity of essence.

/be
Keywords: mozilla0.9.9 → mozilla1.0
Target Milestone: mozilla0.9.9 → mozilla1.0
(Assignee)

Comment 2

16 years ago
Created attachment 73504 [details] [diff] [review]
proposed fix, includes fix for bug 128861
Comment on attachment 73504 [details] [diff] [review]
proposed fix, includes fix for bug 128861

sr=shaver.
Attachment #73504 - Flags: superreview+
(Reporter)

Comment 4

16 years ago
Comment on attachment 73504 [details] [diff] [review]
proposed fix, includes fix for bug 128861

r=dbaron
Attachment #73504 - Flags: review+
(Assignee)

Updated

16 years ago
Priority: P2 → P1

Comment 5

16 years ago
Comment on attachment 73504 [details] [diff] [review]
proposed fix, includes fix for bug 128861

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #73504 - Flags: approval+
(Assignee)

Comment 6

16 years ago
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.