Closed Bug 1209558 Opened 6 years ago Closed 6 years ago

Update pressed_state of search buttons

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: liuche, Assigned: ally)

References

Details

Attachments

(1 file)

The pressed_state for the buttons in Search should not be orange, and should be updated.

When pressed, suggestions should be pressed_grey, and the Yes/No for turning on search suggestions should be link_blue_pressed.
Thanks for filing this!

(In reply to Chenxia Liu [:liuche] from comment #0)
> The pressed_state for the buttons in Search should not be orange, and should
> be updated.
> 
> When pressed, suggestions should be pressed_grey, and the Yes/No for turning
> on search suggestions should be link_blue_pressed.

Just the "Yes" button since that's the only blue button. :)
Flags: needinfo?(ally)
Talked with antlam. No button pressed is to be pressed_grey
Flags: needinfo?(ally)
- depends on patch in 1195614
Attachment #8667550 - Flags: review?(michael.l.comella)
(In reply to Allison Naaktgeboren please NEEDINFO? :ally from comment #2)
> Talked with antlam. No button pressed is to be pressed_grey

Wanted to clarify what you meant here...

this bug is about changing the pressed state of search suggestion pills from toolbar grey to toolbar grey pressed and link blue to link blue pressed right?
Flags: needinfo?(ally)
and the yes/no button press states, as liuche mentioned in comment 0. :D
Flags: needinfo?(ally)
Comment on attachment 8667550 [details] [diff] [review]
changePressedButtonColors v0

Review of attachment 8667550 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/resources/drawable/search_suggestion_prompt_no.xml
@@ +6,5 @@
> +<selector xmlns:android="http://schemas.android.com/apk/res/android">
> +    <item android:state_pressed="true">
> +        <shape>
> +            <solid android:color="@color/toolbar_grey_pressed"/>
> +            <corners android:radius="4dp"/>

It'd be good to use a constant here because the dimension spans multiple files. I filed bug 1210862 to consolidate our use of dimens values, but lets go with doorhanger_rounded_corner_radius for now (here & in search_suggestion_prompt_yes).

::: mobile/android/base/resources/drawable/search_suggestion_prompt_yes.xml
@@ +12,5 @@
> +</item>
> +
> +<item>
> +    <shape>
> +        <solid android:color="@color/link_blue_pressed"/>

The names here are confusing so I just want to double-check you meant to do this – pressed is "link_blue" and not pressed is "link_blue_pressed".
Attachment #8667550 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/d1d59b342a3c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.