1209627 - Remove cruft for initial landing

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Olivier Yiptong [:oyiptong]]

For our initial landing, we want to keep tile decisioning in the privileged context.

However, most of the other messages, like pinning, blocking can go away.

This bug is to track the removal of all of our unused messages in the RemoteAboutNewTab module, and many of those changes will also manifest in RemoteNewTabUtils.

Comment 1

[Olivier Yiptong [:oyiptong]]

An example of work that needs to be done is removing the pinning logic in RemoteNewTabUtils, especially in getLinks.

The messages have already been removed from RemoteAboutNewTab.

Comment 2

[Olivier Yiptong [:oyiptong]]

Actually, upon closer inspection, we may want to keep pinning.

Here's a list of things we want to remove/keep. We should also remove any related code in RemoteNewTabUtils.jsm

There should be no caching in privileged context if possible.

In RemoteAboutNewTab.jsm:

Removing:
* BlockLink
* UnblockLink
* UndoAll
* IntroShown
* ReportSitesAction
* UpdatePages
* InitializeGrid
* Customize
* SpeculativeConnect

Things we keep:
* ReportSiteClicked
* ReplacePinLink
* PageThumbs
* CaptureBackgroundPageThumbs
* UpdateGrid
* GetInit

Comment 3

[Olivier Yiptong [:oyiptong]]

Also removing an erroneous preload rule

Comment 4

[Olivier Yiptong [:oyiptong]]

Had to keep InitializeGrid because the current page expects it