1209705 - ClippedImage should propagate a DrawResult correctly even when it creates an intermediate surface

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

Right now if ClippedImage creates an intermediate surface (by calling GetFrameInternal() in Draw()), it just drops the DrawResult that it generates in DrawSingleTile() on the floor. To support sync decoding for border-image correctly, we need to propagate that DrawResult to the caller.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Propagate the DrawResult for temporary surfaces to the caller in ClippedImage

Here's the patch. This is almost identical to the approach we use in RasterImage
for ImageContainers; we cache the DrawResult that we generate when we create the
cached surface, and then return it to the caller from Draw().

Comment 2

[Seth Fowler [:seth] [:s2h]]

Thanks for the review!

Comment 3

[Seth Fowler [:seth] [:s2h]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d2c675a8830

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d2c675a8830