Closed Bug 1209705 Opened 5 years ago Closed 5 years ago

ClippedImage should propagate a DrawResult correctly even when it creates an intermediate surface

Categories

(Core :: ImageLib, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file)

Right now if ClippedImage creates an intermediate surface (by calling GetFrameInternal() in Draw()), it just drops the DrawResult that it generates in DrawSingleTile() on the floor. To support sync decoding for border-image correctly, we need to propagate that DrawResult to the caller.
Here's the patch. This is almost identical to the approach we use in RasterImage
for ImageContainers; we cache the DrawResult that we generate when we create the
cached surface, and then return it to the caller from Draw().
Attachment #8667500 - Flags: review?(tnikkel)
Attachment #8667500 - Flags: review?(tnikkel) → review+
Thanks for the review!
https://hg.mozilla.org/mozilla-central/rev/4d2c675a8830
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.