120980 - bit column name in groups table not good for database independence

Status: RESOLVED WONTFIX

Description

[David Lawrence [:dkl]]

The bit column in the groups table should be renamed to be group_bit since the
word 'bit' is a reserved key word in some other databases. Most notably,
PostgreSQL. Attaching patch for conversion.

Comment 1

[David Lawrence [:dkl]]

Created attachment 65814 [details] [diff] [review]
Patch to change bit column to group_bit in groups table

Comment 2

[Bradley Baetz (:bbaetz)]

Why bother? You're getting rid of this in the groups rewrite, and thats a prereq
for postgressql support anyway.

Comment 3

[David Lawrence [:dkl]]

Good point. I came across it when working on the PostgreSQL port which doesnt
include the group schema changes. The group schema changes should land before
PostgreSQL so I will go ahead and close this bug. With the group changes, the
bit column will disappear anyway.