1209837 - Sync logs an error after changing password.

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Via bug 1209481, changing your password causes a sync error log to be created. Log at https://docs.google.com/document/d/1ACIaTXk5Y1K5_dZ3aFGriGzU967ZwVcO2A1w3yp7Iz8/edit, and the relevant parts are:

> 1443521328102    FirefoxAccounts    DEBUG    Notifying observers of fxaccounts:onlogout
> 1443521328102    Sync.BrowserIDManager    DEBUG    observed fxaccounts:onlogout
> 1443521328103    Sync.AddonsReconciler    DEBUG    Removing change listener.
> 1443521328103    Sync.AddonsReconciler    DEBUG    Stopping listening and removing AddonManager listeners.
> 1443521328103    Sync.Tracker.History    INFO    Removing Places observer.
> 1443521328104    Sync.Status    INFO    Resetting Status.
> 1443521328104    Sync.Status    DEBUG    Status.service: success.status_ok => success.status_ok
> 1443521328105    Sync.BrowserIDManager    DEBUG    _ensureValidToken already has one
> 1443521328331    Hawk    DEBUG    (Response) /session/destroy: code: 401 - Status text: Unauthorized
> 1443521328331    Sync.RESTResponse    TRACE    Processing response headers.
> 1443521328332    Hawk    DEBUG    Clock offset vs https://api.accounts.firefox.com/v1: -332
> 1443521328332    Hawk    DEBUG    Received 401 for /session/destroy: retrying
> 1443521328568    Hawk    DEBUG    (Response) /session/destroy: code: 401 - Status text: Unauthorized
> 1443521328568    Sync.RESTResponse    TRACE    Processing response headers.
> 1443521328568    Hawk    DEBUG    Clock offset vs https://api.accounts.firefox.com/v1: -568
> 1443521328568    FirefoxAccounts    ERROR    error POSTing /session/destroy: {"code":401,"errno":110,"error":"Unauthorized","message":"Invalid authentication token in request signature","info":"https://github.com/mozilla/fxa-auth-server/blob/master/docs/api.md#response-format"}
> 1443521328568    FirefoxAccounts    ERROR    Error during remote sign out of Firefox Accounts: {"code":401,"errno":110,"error":"Unauthorized","message":"Invalid authentication token in request signature","info":"https://github.com/mozilla/fxa-auth-server/blob/master/docs/api.md#response-format"}
> 1443521328569    FirefoxAccounts    DEBUG    FxAccountsOAuthGrantClient Initialized
> 1443521328813    FirefoxAccounts    DEBUG    Notifying observers of testhelper-fxa-signout-complete
> 1443521328887    Sync.Resource    DEBUG    mesg: DELETE success 200 https://sync-258-us-west-2.sync.services.mozilla.com/1.5/30805819/storage/clients/lST-5V-0Wp47
> 1443521328887    Sync.Resource    DEBUG    DELETE success 200 https://sync-258-us-west-2.sync.services.mozilla.com/1.5/30805819/storage/clients/lST-5V-0Wp47
> 1443521328887    Sync.BrowserIDManager    DEBUG    _ensureValidToken already has one
> 1443521329111    Sync.Resource    DEBUG    mesg: DELETE success 200 https://sync-258-us-west-2.sync.services.mozilla.com/1.5/30805819/storage/tabs/lST-5V-0Wp47
> 1443521329111    Sync.Resource    DEBUG    DELETE success 200 https://sync-258-us-west-2.sync.services.mozilla.com/1.5/30805819/storage/tabs/lST-5V-0Wp47
> 1443521329112    Sync.Service    DEBUG    Finished deleting client data.
> 1443521329112    Sync.Service    INFO    Service.startOver dropping sync key and logging out.
> 1443521329112    Sync.Status    DEBUG    Status.login: success.login => error.login.reason.no_recoverykey
> 1443521329112    Sync.Status    DEBUG    Status.service: success.status_ok => service.client_not_configured
> 1443521329112    Sync.Service    INFO    Logging out

Alexandra, can you please give full STR (ie, it's not clear if the password was changed on this device, and the logs appear you might have explicitly logged out too?)

Comment 1

[Ada [:adalucinet]]

Here are the steps to reproduce:
1. Launch Firefox.
2. Click on one of the available Sync buttons (e.g. about:home, about:preferences#sync, menu panel, Tools)
3. Sign in with an existing account
4. Go to about:preferences#sync, and click "Manage"
5. Click the "Change password" link
6. Provide the requested passwords (old and new)
7. Sign out then sign in again using your new password

Comment 2

[Chris Karlof [:ckarlof]]

Currently, when you change your password, we destroy all existing sessions tokens, which requires you to log in again after changing your password.

The log looks expected. After changing your passwords, attempts to use the previous session token in API calls will result in a 401 response.