Closed
Bug 1209886
Opened 9 years ago
Closed 9 years ago
Clean up InstantiateDecoder() in DecoderTraits.cpp
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ca0986418ca0#l1.156 I guess |NS_ENSURE_TRUE(decoder != nullptr, nullptr);| and |NS_ENSURE_TRUE(decoder->Init(aOwner), nullptr);| accidentally got into the repo for they were not there in the patch of https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=886196&attachment=827215.
|
|
Assignee | |
Comment 2•9 years ago
|
||
Bug 1209886 - Clean up InstantiateDecoder() in DecoderTraits.cpp.
Attachment #8667780 -
Flags: review?(kinetik)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8667780 [details] MozReview Request: Bug 1209886 - Clean up InstantiateDecoder() in DecoderTraits.cpp. https://reviewboard.mozilla.org/r/20821/#review18787 Nice catch.
Attachment #8667780 -
Flags: review?(kinetik) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Thanks!
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/60e935ee832a
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•