If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Clean up InstantiateDecoder() in DecoderTraits.cpp

RESOLVED FIXED in Firefox 44

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Assignee: nobody → jwwang
Depends on: 886196
(Assignee)

Comment 1

2 years ago
https://hg.mozilla.org/mozilla-central/rev/ca0986418ca0#l1.156

I guess |NS_ENSURE_TRUE(decoder != nullptr, nullptr);| and |NS_ENSURE_TRUE(decoder->Init(aOwner), nullptr);| accidentally got into the repo for they were not there in the patch of https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=886196&attachment=827215.
(Assignee)

Comment 2

2 years ago
Created attachment 8667780 [details]
MozReview Request: Bug 1209886 - Clean up InstantiateDecoder() in DecoderTraits.cpp.

Bug 1209886 - Clean up InstantiateDecoder() in DecoderTraits.cpp.
Attachment #8667780 - Flags: review?(kinetik)
Comment on attachment 8667780 [details]
MozReview Request: Bug 1209886 - Clean up InstantiateDecoder() in DecoderTraits.cpp.

https://reviewboard.mozilla.org/r/20821/#review18787

Nice catch.
Attachment #8667780 - Flags: review?(kinetik) → review+
(Assignee)

Comment 4

2 years ago
Thanks!

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/60e935ee832a
https://hg.mozilla.org/mozilla-central/rev/60e935ee832a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.