Closed Bug 1209963 Opened 4 years ago Closed 3 years ago

[Messages][Refactoring] InboxView.deleteThread should not attempt to close notification for the thread-less drafts

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, minor)

ARM
Gonk (Firefox OS)
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: azasypkin, Assigned: varghesethomase, Mentored)

References

Details

(Whiteboard: [good first bug][mentor-lang=ru][lang=js])

We call "InboxView.deleteThread" [1] in several different cases - when we discard draft in Conversation view or delete it when in Inbox view edit mode. Under the hood we always call "Utils.closeNotificationsForThread" [2], but it doesn't make sense in case of conversation-less drafts that can't have any associated notifications.

So in this bug we want to call "Utils.closeNotificationsForThread" only if "InboxView.deleteThread" is called for conversation, not conversation-less draft. It's easy to do if we retrieve conversation with "Threads.get" and check its "isDraft" property.

[1] https://github.com/mozilla-b2g/gaia/blob/ece0c014925c70ec65a0e8cee4e4101664f2ce58/apps/sms/views/inbox/js/inbox.js#L773

[2] https://github.com/mozilla-b2g/gaia/blob/ece0c014925c70ec65a0e8cee4e4101664f2ce58/apps/sms/views/inbox/js/inbox.js#L783
Hi,
Can I work on this? I am not well experienced. So would be great if someone can mentor me.

Thanks
(In reply to varghesethomase from comment #1)
> Hi,
> Can I work on this?

Definitely!

> I am not well experienced. So would be great if someone can mentor me.

Sure, I can mentor you on this bug. First of all you need to go through [1] (only "The basics" section for now) to understand what Gaia is, how to run it and contribute. And then shorter and more Messages app specific guide [2].

If you have any questions you can ping me on this bug or come to IRC channels (#gaia-messaging or #fxos, my IRC nick is :azasypkin) [3].

I'm assigning this bug to you, so that no one else can take it while you're working on it :)

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Developing_Gaia
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/README.md
[3] https://wiki.mozilla.org/IRC
Assignee: nobody → varghesethomase
Status: NEW → ASSIGNED
Hey,

Just wanted to check if you have any questions/troubles, happy to help here!

Anyway, there is no pressure whatsoever :)

Thanks!
Flags: needinfo?(varghesethomase)
Hi, 
I will join you back in 3 days time. A bit busy for the next few days.
Flags: needinfo?(varghesethomase)
Hey,
Any update on this. :) Comment here or come over irc if you stuck somewhere :)
Thanks
Flags: needinfo?(varghesethomase)
Hey!
Sorry i wasn't able to look at it. I need to start over it once again. If this bug is still not solved, i'm ready to work on it. I need help :rishav_
Flags: needinfo?(varghesethomase)
Hey,
Yeah, this bug is still there. you can work on it ?
What help can i do? Can you bit specific ? check description, it's written clearly. So, in this bug, we need to check if thread is conversation-less draft (i.e no any other msg other than draft), then no need to call Utils.closeNotificationsForThread.

Hope it help. Still any issue, feel free to comment
Thanks
Mass closing of Gaia::SMS bugs. End of an era :(
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in before you can comment on or make changes to this bug.