Closed Bug 1209971 Opened 5 years ago Closed 5 years ago

Suggested reviewers should exclude the current user from the list displayed

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: emorley, Assigned: dkl)

Details

Attachments

(1 file)

1) Logged in with my account
2) https://bugzilla.mozilla.org/attachment.cgi?bugid=1192957&action=enter
3) Set r?, and open the suggested reviews list

Expected:
Not see my own account suggested as a reviewer

Actual:
My account included in the list.


(Not urgent in the slightest :-))
Removed from Tree Management :: Treeherder: Docs & Development. I see you are also on several other components in that product as well? Are the others OK?

For a full list: https://bugzilla.mozilla.org/describecomponents.cgi?product=Tree%20Management
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Flags: needinfo?(emorley)
Ah I actually meant that in general the suggested reviewers feature should only suggest other people, not myself - but I see how that could have been misinterpreted :-)
Flags: needinfo?(emorley)
Summary: Suggested reviewers should exclude myself from the list → Suggested reviewers should exclude the current user from the list displayed
(In reply to Ed Morley [:emorley] from comment #2)
> Ah I actually meant that in general the suggested reviewers feature should
> only suggest other people, not myself - but I see how that could have been
> misinterpreted :-)

Ah :) Sorry for the confusion. Yeah that does make sense and should be simple enough to fix with a small code change.

dkl
Attached patch 1209971_1.patchSplinter Review
Attachment #8667952 - Flags: review?(glob)
Comment on attachment 8667952 [details] [diff] [review]
1209971_1.patch

Review of attachment 8667952 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob
Attachment #8667952 - Flags: review?(glob) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   f992c47..0a62094  master -> master
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Many thanks :-)
Component: Extensions: Review → Extensions
You need to log in before you can comment on or make changes to this bug.