1209971 - Suggested reviewers should exclude the current user from the list displayed

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Ed Morley [:emorley]]

1) Logged in with my account
2) https://bugzilla.mozilla.org/attachment.cgi?bugid=1192957&action=enter
3) Set r?, and open the suggested reviews list

Expected:
Not see my own account suggested as a reviewer

Actual:
My account included in the list.


(Not urgent in the slightest :-))

Comment 1

[David Lawrence [:dkl]]

Removed from Tree Management :: Treeherder: Docs & Development. I see you are also on several other components in that product as well? Are the others OK?

For a full list: https://bugzilla.mozilla.org/describecomponents.cgi?product=Tree%20Management

Comment 2

[Ed Morley [:emorley]]

Ah I actually meant that in general the suggested reviewers feature should only suggest other people, not myself - but I see how that could have been misinterpreted :-)

Comment 3

[David Lawrence [:dkl]]

(In reply to Ed Morley [:emorley] from comment #2)
> Ah I actually meant that in general the suggested reviewers feature should
> only suggest other people, not myself - but I see how that could have been
> misinterpreted :-)

Ah :) Sorry for the confusion. Yeah that does make sense and should be simple enough to fix with a small code change.

dkl

Comment 4

[David Lawrence [:dkl]]

Attachment: 1209971_1.patch

Comment 5

[:glob ✱]

Comment on attachment 8667952 [details] [diff] [review]
1209971_1.patch

Review of attachment 8667952 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 6

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   f992c47..0a62094  master -> master

Comment 7

[Ed Morley [:emorley]]

Many thanks :-)