On Android, we have a 'Learn more...' button that takes the user to a SUMO article explaining what private browsing is. This bug is to add the same link for iOS.
Roland, someone mentioned we have a SUMO article that we can link to. Does this need any changes for iOS?
hi stephan: great question, my guess is we will need a separate article for private browsing for iOS since it would be too hard to do conditional markup for android and ios (and we don't yet have conditional markup i.e. "showfor" for ios, that will come in 2016 i think) joni: am i right? if so please create a stub article that stephan et al can link to this week please. (needinfo-ing our fantastic content editor joni savage who writes all english articles for sumo for firefox desktop, ios, android and Firefox os)
3 years ago
How do we want this to look? Darker gray, centered below the empty private tabs tray text?
Created attachment 8669096 [details] Screen Shot 2015-10-02 at 2.53.48 PM.png Same text color as the selected text highlight on the URL bar in private mode (rgb 120/120/165), 15pt system font medium.
Hi, Holly also asked for a private browsing article for iOS, so we've set up a placeholder. Here's the in-product link you can use: https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/private-browsing-ios Just replace the %Version%/%OS%/%Locale% tuple. It will automatically redirect to the SUMO page.
Does this URL look right for US/English locale? Just want to make sure the formats line up. https://support.mozilla.org/1/mobile/1.1/iOS/en_US/private-browsing-ios
Comment on attachment 8669716 [details] [review] https://github.com/mozilla/firefox-ios/pull/1122 Nice! Can we include a down state so we're not tracking these down later (I thought iOS had built in ones for buttons?)... basically a slightly transparent version of the text. + with that nit.
Attachment #8669716 - Flags: ui-review?(dhenein) → ui-review+
(In reply to Stephan Leroux [:sleroux] from comment #6) > Does this URL look right for US/English locale? Just want to make sure the > formats line up. > > https://support.mozilla.org/1/mobile/1.1/iOS/en_US/private-browsing-ios Hi Stephan, it's close. We use "en-us" for English (US) locale.
Thanks! I've added a follow up commit to use the language identifier instead of the locale one: https://github.com/mozilla/firefox-ios/commit/1b2ca44d25bbc76e1faaf547037f9490739608cc
Attachment #8669716 - Flags: review?(etoop) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.