1210164 - Full-screen video should have touchscreen-friendly controls

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Audio/Video, enhancement, P3)

Description

[Alex]

Attachment: mx-player041.jpg

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20150930030231

Steps to reproduce:

When viewing a video with Firefox on Android in fullscreen, the controls are very cumbersome and not touchscreen-friendly at all.


Actual results:

In comparison to some other video players/browsers, it's hard to seek through a video or change the volume.


Expected results:

Firefox should offer similar video controls as the competition. See for example the attached screenshot for MX Player's and Dolphin Browser's video controls. Slide vertically on the left to change brightness, on the right to change volume, horizontally to seek.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

I thought we had a similar bug on file but I can't find it. Might be an interesting extension.

Comment 2

[Barbara Bermes [:barbara] - NI please!]

barbara to create Aha card

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Not tracking till we have resources to accomplish the work.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I notice that the controls use whatever zoom level the page was at before going full-screen. If you pinch-zoom in the page, then go full-screen, the controls are bigger.

What we need is a way to force the controls to a zoom level we think is appropriate for full-screen.

Kats - Do you have any ideas for how to change the zoom, temporarily, when going full-screen?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

So comment 4 at least is a dupe of bug 791192.

That being said, I haven't given much thought to changing the zoom while in fullscreen; all my previous attempts at fixing this have been along the lines of making stuff work better even with a zoom. Forcing the zoom to 1 might be doable, but would take a bunch of plumbing since it's the APZ (on desktop/b2g) or Java code (on Fennec) that "owns" the zoom and so you would have send it a message about going in and out of fullscreen. Are there existing hooks to know when go in and out of video fullscreen (which I recently discovered is different from calling mozRequestFullScreen)? If so we can try hooking them up and see if this approach works.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

the video controls have a button to toggle fullscreen:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/videocontrols.xml?force=1#1061

It looks like it uses videoElement.mozRequestFullScreen()

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Mark Finkle (:mfinkle) from comment #6)
> the video controls have a button to toggle fullscreen:
> http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/
> videocontrols.xml?force=1#1061
> 
> It looks like it uses videoElement.mozRequestFullScreen()

I'm going to move this to bug 791192. This bug is really about something completely different. My bad.

Comment 8

[:Margaret Leibovic]

Is this a dupe of bug 704229? Maybe we should close that bug and just implement something simple here instead.

Comment 9

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to :Margaret Leibovic from comment #8)
> Is this a dupe of bug 704229? Maybe we should close that bug and just
> implement something simple here instead.

Yeah this feels like a dupe. Wesj mentioned that it's been hard getting into this part of the code. Perhaps this is better scoped? (just full screen controls first).

Can we try swapping the icons?

Comment 10

[:Margaret Leibovic]

I'm going to dupe this to bug 704229.

Comment 11

[Kevin Brosnan [Ex-Mozilla]]

This request was more than an icon swap. It was for gestures in fullscreen video for at least volume and scrubbing.

Comment 12

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.