Closed Bug 1210170 Opened 4 years ago Closed 4 years ago

webrtc.org simulcast support

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox44 --- affected
firefox46 --- fixed
Blocking Flags:

People

(Reporter: bwc, Assigned: jesup)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

webrtc.org will need to be taught a couple of new tricks:

1) To support the sending of the RID RTP header extension that is soon to be defined in the mmusic rid draft, and API that allows the RID value to be set on a given simulcast stream.

2) To support setting the payload type on a given simulcast stream (right now, it is set only on the channel as a whole).
Taking for breakdown
Assignee: nobody → rjesup
backlog: --- → webrtc/webaudio+
Rank: 10
Priority: -- → P1
Works!  Some rough edges, and a kludge around how it interacts with simulcast streams (need to talk to Byron about the API
Ugly/simple test patch
Blocks: 1230197
I kept the interface for setting the rid on a single stream because it's easy, and may be handy for testing or other uses
Attachment #8697380 - Flags: review?(pkerr)
Attachment #8696188 - Attachment is obsolete: true
Comment on attachment 8697380 [details] [diff] [review]
WIP patch to add RID send/receive/query support to webrtc.org code

Review of attachment 8697380 [details] [diff] [review]:
-----------------------------------------------------------------

See my comment on strlen() usage. Is the comment wrong on that line?

::: media/webrtc/trunk/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
@@ +1427,5 @@
> +    // Not registered.
> +    return 0;
> +  }
> +  size_t pos = 0;
> +  const uint8_t len = strlen(rid_); // not null-terminated

rid_ is not null-terminated? How is strlen() handling this?
Attachment #8697380 - Flags: review?(pkerr) → review+
Comment on attachment 8697078 [details] [diff] [review]
WIP patch to add rid settings to simulcast structure

merged into the other patch
Attachment #8697078 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/c30748ca0ba8
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.