1210170 - webrtc.org simulcast support

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Byron Campen [:bwc]]

webrtc.org will need to be taught a couple of new tricks:

1) To support the sending of the RID RTP header extension that is soon to be defined in the mmusic rid draft, and API that allows the RID value to be set on a given simulcast stream.

2) To support setting the payload type on a given simulcast stream (right now, it is set only on the channel as a whole).

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Taking for breakdown

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP patch to add RID send/receive/query support to webrtc.org code

Works!  Some rough edges, and a kludge around how it interacts with simulcast streams (need to talk to Byron about the API

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Test patch for RID (NOT FOR CHECKIN!)

Ugly/simple test patch

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP patch to add rid settings to simulcast structure

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP patch to add RID send/receive/query support to webrtc.org code

I kept the interface for setting the rid on a single stream because it's easy, and may be handy for testing or other uses

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=84a251530e65

Comment 7

[Paul Kerr [:pkerr]]

Comment on attachment 8697380 [details] [diff] [review]
WIP patch to add RID send/receive/query support to webrtc.org code

Review of attachment 8697380 [details] [diff] [review]:
-----------------------------------------------------------------

See my comment on strlen() usage. Is the comment wrong on that line?

::: media/webrtc/trunk/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
@@ +1427,5 @@
> +    // Not registered.
> +    return 0;
> +  }
> +  size_t pos = 0;
> +  const uint8_t len = strlen(rid_); // not null-terminated

rid_ is not null-terminated? How is strlen() handling this?

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8697078 [details] [diff] [review]
WIP patch to add rid settings to simulcast structure

merged into the other patch

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c30748ca0ba8

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c30748ca0ba8