Closed Bug 1210208 Opened 4 years ago Closed 3 years ago

Intermittent browser_cmd_highlight_01.js | This test exceeded the timeout threshold.

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

defect
Not set

Tracking

(firefox45 wontfix, firefox46 wontfix, firefox47 wontfix, firefox48 fixed, firefox-esr45 fixed, firefox50 unaffected, firefox51 unaffected, firefox52 fixed, firefox53 fixed)

RESOLVED FIXED
Firefox 53
Tracking Status
firefox45 --- wontfix
firefox46 --- wontfix
firefox47 --- wontfix
firefox48 --- fixed
firefox-esr45 --- fixed
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: KWierso, Assigned: miker)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

No description provided.
Matteo, who could look into this?  It's currently on the list of top 30 intermittents.
Component: Developer Tools → Developer Tools: Graphic Commandline and Toolbar
Flags: needinfo?(zer0)
Bug 384336 seems to make this more frequent if not permanent. I'm going to disable the test on Linux.
Blocks: 384336
Whiteboard: [test disabled]
There's an awful lot of sub test cases in this test that, in fact, really just test the gcli command prompt behavior, not the command logic itself.
We should get rid of some of those.
If this test intermittently fails because it runs for too long, then removing some of the test cases in this test should help make it faster.
I would try to reduce the number of the element created in the page, and check as Patrick said, if we can remove some of the tests, and see if it's helping.
I wasn't able to reproduce locally the bug, in a Linux VM: I followed the wiki (https://wiki.mozilla.org/DevTools/Intermittents) and also I tried to limit the memory of my VM but without much success.

So as mentioned in my previous comment, I reduce the number of the element created in the test, and move all the tests unrelated to nodes to another test (highlight_03).
Flags: needinfo?(zer0)
Comment on attachment 8732347 [details]
MozReview Request: Bug 1210208 - Intermittent browser_cmd_highlight_01.js | This test exceeded the timeout threshold.; r=miker

https://reviewboard.mozilla.org/r/41117/#review38417
Attachment #8732347 - Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/mozilla-central/rev/0d60f0d8b5e0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Lasted a couple of months, anyway, that's not terrible.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Mike, this test seems to start failing frequently again. Could you keep an eye on it? And perhaps see if there's another way to make it run faster?
Flags: needinfo?(mratcliffe)
Let's try dividing it further or it will always cause intermittents when our infrastructure is under load.
Assignee: nobody → mratcliffe
Flags: needinfo?(mratcliffe)
They all appear to be browser_cmd_highlight_01.js failures so I will divide that.
Comment on attachment 8803861 [details] [diff] [review]
1210208-split-browser_cmd_highlight_01-js.diff

Review of attachment 8803861 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like a simple-enough test split to me. Thanks for fixing this quickly Mike.
Attachment #8803861 - Flags: review?(pbrosset) → review+
Looks like this intermittent is more frequent since last week. 
Any reason why the reviewed patch didn't land?
Flags: needinfo?(mratcliffe)
Nope, just missing checkin-needed.
Flags: needinfo?(mratcliffe)
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c861b79fc961
Split browser_cmd_highlight_01.js r=pbro
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c861b79fc961
Status: REOPENED → RESOLVED
Closed: 4 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 48 → Firefox 53
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.