Closed Bug 1210208 Opened 4 years ago Closed 3 years ago
_cmd _highlight _01 .js | This test exceeded the timeout threshold .
MozReview Request: Bug 1210208 - Intermittent browser_cmd_highlight_01.js | This test exceeded the timeout threshold.; r=miker
58 bytes, text/x-review-board-request
7.43 KB, patch
|Details | Diff | Splinter Review|
No description provided.
Matteo, who could look into this? It's currently on the list of top 30 intermittents.
Component: Developer Tools → Developer Tools: Graphic Commandline and Toolbar
Bug 384336 seems to make this more frequent if not permanent. I'm going to disable the test on Linux.
There's an awful lot of sub test cases in this test that, in fact, really just test the gcli command prompt behavior, not the command logic itself. We should get rid of some of those. If this test intermittently fails because it runs for too long, then removing some of the test cases in this test should help make it faster.
I would try to reduce the number of the element created in the page, and check as Patrick said, if we can remove some of the tests, and see if it's helping.
Review commit: https://reviewboard.mozilla.org/r/41117/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41117/
Attachment #8732347 - Flags: review?(mratcliffe)
I wasn't able to reproduce locally the bug, in a Linux VM: I followed the wiki (https://wiki.mozilla.org/DevTools/Intermittents) and also I tried to limit the memory of my VM but without much success. So as mentioned in my previous comment, I reduce the number of the element created in the test, and move all the tests unrelated to nodes to another test (highlight_03).
Comment on attachment 8732347 [details] MozReview Request: Bug 1210208 - Intermittent browser_cmd_highlight_01.js | This test exceeded the timeout threshold.; r=miker https://reviewboard.mozilla.org/r/41117/#review38417
Attachment #8732347 - Flags: review?(mratcliffe) → review+
Lasted a couple of months, anyway, that's not terrible.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Mike, this test seems to start failing frequently again. Could you keep an eye on it? And perhaps see if there's another way to make it run faster?
Let's try dividing it further or it will always cause intermittents when our infrastructure is under load.
Assignee: nobody → mratcliffe
They all appear to be browser_cmd_highlight_01.js failures so I will divide that.
3 years ago
Attachment #8732347 - Flags: checkin+
Comment on attachment 8803861 [details] [diff] [review] 1210208-split-browser_cmd_highlight_01-js.diff Review of attachment 8803861 [details] [diff] [review]: ----------------------------------------------------------------- Looks like a simple-enough test split to me. Thanks for fixing this quickly Mike.
Attachment #8803861 - Flags: review?(pbrosset) → review+
Looks like this intermittent is more frequent since last week. Any reason why the reviewed patch didn't land?
Nope, just missing checkin-needed.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c861b79fc961 Split browser_cmd_highlight_01.js r=pbro
You need to log in before you can comment on or make changes to this bug.