1210226 - Handle nicknames that contain spaces for msg and kick commands in XMPP

Status: RESOLVED FIXED

(Chat Core :: XMPP, defect)

Description

[Abdelrahman Ahmed [:abdelrahman]]

Handle nicknames that contain spaces for msg and kick commands in XMPP.

Comment 1

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: Handle nickname with space

Comment 2

[aleth [:aleth]]

Comment on attachment 8681650 [details] [diff] [review]
Handle nickname with space

Review of attachment 8681650 [details] [diff] [review]:
-----------------------------------------------------------------

Nice improvement!

::: chat/protocols/xmpp/xmpp-commands.jsm
@@ -213,5 @@
> -
> -      if (!conv._participants.has(nickName)) {
> -        conv.writeMessage(conv.name,
> -                          _("conversation.error.nickNotInRoom", nickName),
> -                          {system: true});

Would be nice to keep this error message. Maybe even move it to splitByNick and show it when no nick is found.

Comment 3

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: Handle nickname with spaces

Comment 4

[aleth [:aleth]]

Comment on attachment 8682477 [details] [diff] [review]
Handle nickname with spaces

Review of attachment 8682477 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/6fe88dd01169a34338efc6092ccc0d674af7bc3c
Bug 1210226 - Handle nicknames that contain spaces for msg and kick commands in XMPP. r=aleth chat/ patch on CLOSED TREE