1210240 - Do some telemetry for potential subject-principal crash sites

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bobby Holley (:bholley)]

Without bug 1209131, we can't get stacks for potential culprits that will run afoul of the more stringent checks added in bug 1072150. But we can at least measure the rough crash rate that we can expect by turning those checks on again. Let's see what that looks like.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Do some telemetry for potential subject-principal crash sites. v1

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8668183 [details] [diff] [review]
Do some telemetry for potential subject-principal crash sites. v1

Review of attachment 8668183 [details] [diff] [review]:
-----------------------------------------------------------------

Simple enough, but you should add an "alert_emails" entry for the histogram.

Still needs data collection peer approval, moving to vladan for this simple probe.

Comment 3

[Vladan Djeric (:vladan)]

Comment on attachment 8668183 [details] [diff] [review]
Do some telemetry for potential subject-principal crash sites. v1

Review of attachment 8668183 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Histograms.json
@@ +5316,5 @@
>    },
> +  "SUBJECT_PRINCIPAL_ACCESSED_WITHOUT_SCRIPT_ON_STACK": {
> +    "expires_in_version": "46",
> +    "kind": "flag",
> +    "description": "Whether the subject principal was accessed without script on the stack during the current session"

add an alert_emails field so we know who "owns" this histogram. This can be you or ideally some team mailing alias. Alternately, you can just tell us which (well monitored) component to file bugs in via the description field.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffa6d214f96b

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ffa6d214f96b