1210315 - Add a preference to control whether to use long tap injector

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

This bug is to implement item 1) in bug 1203879 comment #0.

1) Use synthesized long-tap event or not. We should turn this on for the platforms which do not enable APZ yet or APZ does not support long-tap events.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: MozReview Request: Bug 1210315 - Use preference to control whether to use long tap injector. r=roc

Bug 1210315 - Use preference to control whether to use long tap injector. r=roc

In AccessibleCaretEventHub, it is not accurate to use APZ enabled to
determine whether to use long tap injector. On desktop browser, there's
no long tap events even if APZ is enabled. We should use a preference to
control that.

Since it's a fact the APZ on b2g has long tap events, we should use
preference to disable long tap injector so that when long tap events
stop dispatching to AccessibleCaretEventHub, we'll know immediately.

Delete SetUseAsyncPanZoom() usage in gtest since APZ is not related to
scrolling in AccessibleCaretEventHub.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: MozReview Request: Bug 1210315 - Inline selectors in carets tests. r=automatedtester

Bug 1210315 - Inline selectors in carets tests. r=automatedtester

All of them are used only once. It reads better to inline them.

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: MozReview Request: Bug 1210315 - Use pref utilities in test_touchcaret.py. r=automatedtester

Bug 1210315 - Use pref utilities in test_touchcaret.py. r=automatedtester

Use the preferences utilities introduced in bug 1164124.

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: MozReview Request: Bug 1210315 - Use pref utilities in test_selectioncarets.py. r=automatedtester

Bug 1210315 - Use pref utilities in test_selectioncarets.py. r=automatedtester

Use the preferences utilities introduced in bug 1164124.

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: MozReview Request: Bug 1210315 - Disable long tap injector in marionette tests. r=automatedtester

Bug 1210315 - Disable long tap injector in marionette tests. r=automatedtester

We send synthesized long tap events in marionette tests in bug 1209841.
No need to use long tap injector.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8668976 [details]
MozReview Request: Bug 1210315 - Use preference to control whether to use long tap injector. r=roc

https://reviewboard.mozilla.org/r/21077/#review19097

Comment 7

[David Burns :automatedtester]

Comment on attachment 8668977 [details]
MozReview Request: Bug 1210315 - Inline selectors in carets tests. r=automatedtester

https://reviewboard.mozilla.org/r/21079/#review19111

Comment 8

[David Burns :automatedtester]

Comment on attachment 8668978 [details]
MozReview Request: Bug 1210315 - Use pref utilities in test_touchcaret.py. r=automatedtester

https://reviewboard.mozilla.org/r/21081/#review19113

Comment 9

[David Burns :automatedtester]

Comment on attachment 8668979 [details]
MozReview Request: Bug 1210315 - Use pref utilities in test_selectioncarets.py. r=automatedtester

https://reviewboard.mozilla.org/r/21083/#review19115

Comment 10

[David Burns :automatedtester]

Comment on attachment 8668980 [details]
MozReview Request: Bug 1210315 - Disable long tap injector in marionette tests. r=automatedtester

https://reviewboard.mozilla.org/r/21085/#review19117

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/75b915c26678
https://hg.mozilla.org/integration/mozilla-inbound/rev/52c1bc8abbf0
https://hg.mozilla.org/integration/mozilla-inbound/rev/d37a973b5df7
https://hg.mozilla.org/integration/mozilla-inbound/rev/93a3e205d67a
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bde155634dc

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/75b915c26678
https://hg.mozilla.org/mozilla-central/rev/52c1bc8abbf0
https://hg.mozilla.org/mozilla-central/rev/d37a973b5df7
https://hg.mozilla.org/mozilla-central/rev/93a3e205d67a
https://hg.mozilla.org/mozilla-central/rev/2bde155634dc