Closed Bug 1210347 Opened 6 years ago Closed 6 years ago

Don't automatically uppercase the first character of the connection types in about:webrtc

Categories

(Core :: WebRTC, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed
Blocking Flags:

People

(Reporter: aryx, Assigned: aryx)

Details

Attachments

(1 file)

aboutWebrtc.js calls renderTransportStats: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/aboutwebrtc/aboutWebrtc.js#568

That calls labelize on the type argument: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/aboutwebrtc/aboutWebrtc.js#528

And that forces uppercase for the first character of the type label independent from the language: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/aboutwebrtc/aboutWebrtc.js#577

Automatically upper- or lowercasing can change the meaning in some languages. If you need the label in upper- and lowercase, please define two different l10n entities.
backlog: --- → webrtc/webaudio+
Rank: 22
Priority: -- → P2
Attached patch patch, v1Splinter Review
Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED
Attachment #8670153 - Flags: review?(mdeboer)
Comment on attachment 8670153 [details] [diff] [review]
patch, v1

Review of attachment 8670153 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! Thanks!
Attachment #8670153 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/mozilla-central/rev/ea8b6281c4f4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.