Closed
Bug 1210347
Opened 10 years ago
Closed 10 years ago
Don't automatically uppercase the first character of the connection types in about:webrtc
Categories
(Core :: WebRTC, defect, P2)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
backlog | webrtc/webaudio+ |
People
(Reporter: aryx, Assigned: aryx)
Details
Attachments
(1 file)
3.49 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
aboutWebrtc.js calls renderTransportStats: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/aboutwebrtc/aboutWebrtc.js#568
That calls labelize on the type argument: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/aboutwebrtc/aboutWebrtc.js#528
And that forces uppercase for the first character of the type label independent from the language: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/aboutwebrtc/aboutWebrtc.js#577
Automatically upper- or lowercasing can change the meaning in some languages. If you need the label in upper- and lowercase, please define two different l10n entities.
Updated•10 years ago
|
backlog: --- → webrtc/webaudio+
Rank: 22
Priority: -- → P2
![]() |
Assignee | |
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8670153 [details] [diff] [review]
patch, v1
Review of attachment 8670153 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM! Thanks!
Attachment #8670153 -
Flags: review?(mdeboer) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•