1210349 - MessageSender should carry tabs.Tab if the connection/message was opened/sent from a tab

Status: RESOLVED WORKSFORME

(WebExtensions :: Untriaged, defect)

Description

[Edgar Chen [:edgar]]

Please see https://developer.chrome.com/extensions/runtime#type-MessageSender.
And we don't support this yet.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

We do try to support this, although it might be broken. Are you testing on desktop or b2g? The desktop code is here:
http://mxr.mozilla.org/mozilla-central/source/browser/components/extensions/ext-tabs.js#17
On b2g we don't support the tabs API yet so there isn't any way to fill this field in.

Comment 2

[Edgar Chen [:edgar]]

(In reply to Bill McCloskey (:billm) from comment #1)
> We do try to support this, although it might be broken. Are you testing on
> desktop or b2g? The desktop code is here:
> http://mxr.mozilla.org/mozilla-central/source/browser/components/extensions/
> ext-tabs.js#17
> On b2g we don't support the tabs API yet so there isn't any way to fill this
> field in.

I am testing on desktop.
Thanks for this information. I thought we did not implement it.

Comment 3

[Edgar Chen [:edgar]]

I found the MessageSender seem not carry tab information while I am trying adblocker+. I will do more tests and also check the code. Thank you.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Do you mean Adblock Plus? I've been testing with the Chrome version of Adblock Plus for a while and it seems to work well for me. Where is the error happening?

Comment 5

[Edgar Chen [:edgar]]

I wrote a test extension to test this and it works good. And in fact there is a mochitest test which will do some checks on sender.tab, https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/test/mochitest/test_ext_sendmessage_reply.html#18.
Sorry about this false alarm.