1210381 - "Copy Link Location" in "View Source" copies a view-source: URL, which is broken

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Nathan Froyd [:froydnj]]

STR:

1. Open view-source on a web page.
2. Right-click on a URL, select "Copy Link Location"

Expected results:

The URL for the link is copied to the clipboard.

Actual results:

The view-source URL for the link is copied to the clipboard.

The actual results are *never* what I want.  Because of this regression, I have to either manually fixup the link after pasting it, or carefully select the link text in the view-source view, which is tedious.  Avoiding this tedious operation is exactly why the "Copy Link Location" menu item was added in bug 469434.

I'm guessing this is a regression from bug 1067325, but I would like confirmation of that.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

(In reply to Nathan Froyd [:froydnj] from comment #0)
> I'm guessing this is a regression from bug 1067325, but I would like
> confirmation of that.

mozregression agrees.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Exciting!  Never knew it worked that way before.  I'll take a look.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1210381 - Remove view-source: when copying links. r=mconley

Bug 1210381 - Remove view-source: when copying links. r=mconley

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe3a86ef8f2b

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8668695 [details]
MozReview Request: Bug 1210381 - Remove view-source: when copying links. r=mconley

https://reviewboard.mozilla.org/r/21015/#review18999

LGTM - thanks jryans!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/41b849d4b94a

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/41b849d4b94a

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Regression, tracking.

Ryan, could you fill the uplift request to aurora & beta? Thanks

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8668695 [details]
MozReview Request: Bug 1210381 - Remove view-source: when copying links. r=mconley

Approval Request Comment
[Feature/regressing bug #]: Bug 1067325, view source in tab
[User impact if declined]: "Copy Link Location" will include "view-source:" prefix, which is not desired
[Describe test coverage new/current, TreeHerder]: On m-c, updated tests.
[Risks and why]: Low
[String/UUID change made/needed]: None

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8668695 [details]
MozReview Request: Bug 1210381 - Remove view-source: when copying links. r=mconley

Fix a regression, taking it. Should 42 beta 5

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8d226d0c17c5

Comment 13

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/878f69bf2908