1210446 - AutoProfilerTracing should also push label frames

Status: REOPENED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Why? Because if you are looking at some traced some operation, wouldn't you also expect it to show up in the call tree? For example, you see this in the waterfall view:

|----------------------- Function Call ----------------------------|
            |------------ Parse HTML -----------------|

And you select just the function call region. Wouldn't you expect the call tree to have a "Parse HTML" node? I would.

On the platform side, this should be easy: add a SamplerStackFrameRAII member in Auto[Global]TimelineMarker.

On the devtools JS side, we only show the category of psuedo frames. We may need a way to somehow whitelist certain psuedo frames so that we get the label properly, or add a ton of new categories for each marker we trace. The former seems much more manageable to me.

Victor, I can take this now, but if it is going to interfere with all the marker refactoring you're doing then I would rather hold off and let you get that done first.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Nick Fitzgerald [:fitzgen][:nf] from comment #0)
> Wouldn't you expect the call
> tree to have a "Parse HTML" node? I would.

To be clear: right now, most of it just shows up as "Gecko" which isn't as useful.

Comment 2

[Victor Porof [:vporof][:vp]]

This sounds really nice. Everything should stabilize completely after bug 1202657 lands, I'd suggest waiting on that just to make your life easier. Will update the docs asap.

Comment 3

[Victor Porof [:vporof][:vp]]

Triaging. Filter on ADRENOCORTICOTROPIC (yes).

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This report is related to the old DevTools Profiler.
The Performance panel now points to the new Firefox profiler available at profiler.firefox.com
Closing as Invalid bug

Comment 5

[Julien Wajsberg [:julienw]]

I think this is still an interesting idea for the new profiler, but I'm moving this to the Gecko Profiler component for retriaging.

Comment 6

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

I think this would be an interesting thing and it should be relatively easy to implement as well.
Maybe we can bump it to P2 but considering our backlog, P3 makes more sense to me. Considering that it's not a huge work, maybe we can bump it. Let me know if you disagree.

Comment 7

[Julien Wajsberg [:julienw]]

Moving to P2 because we moved it to our internal TODO list.