Closed Bug 1210450 Opened 6 years ago Closed 6 years ago

Update esomin to use latest esprima

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jrburke, Assigned: jrburke)

Details

Attachments

(1 file)

build/esomin/esprima.js is currently at 2.4.1, which supports some ES2015 features. esprima 2.6.0 has expanded its ES2015 support, and for email conversations branch builds, we are using enough of the newer features where 2.4.1 cannot parse the files where 2.6.0 can.

So this is just a dependency version update for apps the use esomin, which is currently just email. A very targeted fix with very localized effects. I will attach a pull request soon.
Comment on attachment 8668529 [details] [review]
[gaia] jrburke:bug1210450-esomin-esprima-update > mozilla-b2g:master

Just updates the file to esprima 2.6.0. Tested via VERBOSE=1 and confirmed no errors in minification, tested email app afterwards and continues to work.
Attachment #8668529 - Flags: review?(poirot.alex)
Comment on attachment 8668529 [details] [review]
[gaia] jrburke:bug1210450-esomin-esprima-update > mozilla-b2g:master

Sorry for the delay, I'm not following gaia dev closely.
You may want to ask ricky, who is more active.
Attachment #8668529 - Flags: review?(poirot.alex) → review+
Merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/397f07e37981640cf22f6741f91a836c63f107d6

from pull request:
https://github.com/mozilla-b2g/gaia/pull/32170
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.