Cycle collect DataTransfer::mItems

RESOLVED FIXED in Firefox 44

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8671408 [details] [diff] [review]
part 1 - Use nsVariantCC in various places.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=019f65ad5a66

Most of these will end up in DataTransfer:mItems, so this is needed
for it to do anything useful.
Attachment #8671408 - Flags: review?(bugs)
(Assignee)

Comment 2

2 years ago
Created attachment 8671409 [details] [diff] [review]
part 2 - Cycle collect DataTransfer::mItems.
Attachment #8671409 - Flags: review?(bugs)

Updated

2 years ago
Attachment #8671409 - Flags: review?(bugs) → review+

Comment 3

2 years ago
Comment on attachment 8671408 [details] [diff] [review]
part 1 - Use nsVariantCC in various places.

I wouldn't mind adding mainthread check to MediaManager::ToJSArray
(looks like it is called on main thread only)
Attachment #8671408 - Flags: review?(bugs) → review+

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f665fef765b
https://hg.mozilla.org/integration/mozilla-inbound/rev/9df7af61aff8
(Assignee)

Comment 5

2 years ago
(In reply to Olli Pettay [:smaug] from comment #3)
> I wouldn't mind adding mainthread check to MediaManager::ToJSArray
> (looks like it is called on main thread only)

Yeah, I had that in an earlier version of the patch, but I wasn't sure if it made sense or not. But now that you also think it should be there, I put it back in.
https://hg.mozilla.org/mozilla-central/rev/8f665fef765b
https://hg.mozilla.org/mozilla-central/rev/9df7af61aff8
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.