Closed Bug 1210591 Opened 4 years ago Closed 4 years ago

Cycle collect DataTransfer::mItems

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(2 files)

No description provided.
try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=019f65ad5a66

Most of these will end up in DataTransfer:mItems, so this is needed
for it to do anything useful.
Attachment #8671408 - Flags: review?(bugs)
Attachment #8671409 - Flags: review?(bugs) → review+
Comment on attachment 8671408 [details] [diff] [review]
part 1 - Use nsVariantCC in various places.

I wouldn't mind adding mainthread check to MediaManager::ToJSArray
(looks like it is called on main thread only)
Attachment #8671408 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #3)
> I wouldn't mind adding mainthread check to MediaManager::ToJSArray
> (looks like it is called on main thread only)

Yeah, I had that in an earlier version of the patch, but I wasn't sure if it made sense or not. But now that you also think it should be there, I put it back in.
https://hg.mozilla.org/mozilla-central/rev/8f665fef765b
https://hg.mozilla.org/mozilla-central/rev/9df7af61aff8
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.