1210591 - Cycle collect DataTransfer::mItems

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Use nsVariantCC in various places.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=019f65ad5a66

Most of these will end up in DataTransfer:mItems, so this is needed
for it to do anything useful.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Cycle collect DataTransfer::mItems.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8671408 [details] [diff] [review]
part 1 - Use nsVariantCC in various places.

I wouldn't mind adding mainthread check to MediaManager::ToJSArray
(looks like it is called on main thread only)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f665fef765b
https://hg.mozilla.org/integration/mozilla-inbound/rev/9df7af61aff8

Comment 5

[Andrew McCreight [:mccr8]]

(In reply to Olli Pettay [:smaug] from comment #3)
> I wouldn't mind adding mainthread check to MediaManager::ToJSArray
> (looks like it is called on main thread only)

Yeah, I had that in an earlier version of the patch, but I wasn't sure if it made sense or not. But now that you also think it should be there, I put it back in.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8f665fef765b
https://hg.mozilla.org/mozilla-central/rev/9df7af61aff8