1210614 - wrong poster image for all videos but the most recent one

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[David Flanagan [:djf]]

STR:

1) Launch camera.
2) record two short videos, each with a different subject.
3) Tap on the circle to preview the videos, and swipe sideways to preview the first video you took.
4) Note that the video displays the poster image of the most recent video you took instead of its own poster image.
5) Go back to camera and record another video
6) Return the the preview and notice that all three videos now show the poster image of this new most recent video.

Comment 1

[David Flanagan [:djf]]

[Blocking Requested - why for this release]:

This happens on a Flame running a nightly build from a few days ago. My Aries device is out of date and video recording is not working, so I can't test there.

But if this reproduces for anyone other than me, then I think we should block on it.

Comment 2

[David Flanagan [:djf]]

I'd be willing to bet a small amount of money that the problem is in the code that sends the 'newmedia' event. For videos this is an object with a poster property and the value of that property is another object.  I suspect that we're using the same object for all poster images, and not doing a proper deep copy on it when needed.

Andrew: did your change to the way that posters are generated affect the newmedia code path?

Comment 3

[Max Murrell [MMurrell]]

Following STR Bug 1210614 repros on Aries and Flame 2.5, it does not repro on Flame 2.2.  

Repros on
Environmental Variables:
Device: Flame 2.5
BuildID: 20150727074921
Gaia: 4e3e21a4ba3f188b45623ee2297f21d0791f8667
Gecko: 21ca97268bae
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 42.0a1 (2.5) 
Firmware Version: v18D
 
Repros on
Environmental Variables:
Device: Aries 2.5
BuildID: 20151005111147
Gaia: b994cedaa7ef9bfadcbe841601d9dc8d2e5379f9
Gecko: 45f01961ecd0ad9a45067f3e08bfb92539042eeb
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf

Does not repro on
Environmental Variables:
Device: Flame 2.2
BuildID: 20150112010228
Gaia: f5e481d4caf9ffa561720a6fc9cf521a28bd8439
Gecko: bb8d6034f5f2
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2) 
Firmware Version: v18D

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Let's get a window on this issue.

Comment 5

[Max Murrell [MMurrell]]

B2G Inbound Regression Window:

Last Working 
Environmental Variables:
Device: Flame 2.5
BuildID: 20150730044442
Gaia: 5e31fb6f88cd8c42e53214183defa2ffd455ea00
Gecko: 3595d5849dfc
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5) 
Firmware Version: v18D

First Broken 
Environmental Variables:
Device: Flame 2.5
BuildID: 20150730051841
Gaia: d77579a3d6224ceefcdf26b7d2a9785a2de45c87
Gecko: 63c691cc05d8
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5) 
Firmware Version: v18D


Last Working gaia / First Broken gecko - Issue does not occur 
Gaia: 5e31fb6f88cd8c42e53214183defa2ffd455ea00
Gecko: 63c691cc05d8

First Broken gaia / Last Working gecko - Issue does occur
Gaia: d77579a3d6224ceefcdf26b7d2a9785a2de45c87
Gecko: 3595d5849dfc

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/5e31fb6f88cd8c42e53214183defa2ffd455ea00...d77579a3d6224ceefcdf26b7d2a9785a2de45c87

Comment 6

[Max Murrell [MMurrell]]

This is caused by changes made in Bug 1164200

Comment 7

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Andrew the changes for bug 1164200 seem to have caused this issue.  Can you please take a look?

Comment 8

[David Flanagan [:djf]]

I've got a one-line fix for this. Stealing it from Andrew.

Comment 9

[David Flanagan [:djf]]

Jayme,

Based on comment #2 there wasn't really any need to take the time to do a regression window. It was an easy bug that only needed 20 minutes of my time or of Andrew's time.  Sorry that you spent so much time on it.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] davidflanagan:bug1210614 > mozilla-b2g:master

Comment 11

[David Flanagan [:djf]]

Comment on attachment 8671038 [details] [review]
[gaia] davidflanagan:bug1210614 > mozilla-b2g:master

As I suspected, this was a deep copy issue. The fix is just one line.

Comment 12

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8671038 [details] [review]
[gaia] davidflanagan:bug1210614 > mozilla-b2g:master

LGTM. I incorrectly thought mix would not recursively go through the child elements, good to know thanks ;).

Comment 13

[David Flanagan [:djf]]

Landed on master: https://github.com/mozilla-b2g/gaia/commit/e273efa7647d52c55290c1bca25bb6a2cd796af9

Comment 14

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Thanks David.  We will verify this when it shows up in the nightly builds.

Comment 15

[Carrie.Yang Leave from Mozilla]

This bug has been verified as pass on latest build of Flame KK v2.5 & Aries KK v2.5 by the STR in Comment 0.
Actual results: All videos now show the poster image of its own poster image.
See attachment: Verfied_Aries_v2.5.3gp.
Reproduce rate: 0/10

Device:Flame v2.5(Pass)
Build ID               20151008150210
Gaia Revision          e698df503ff700eb5782e3d50c6eb753567d3451
Gaia Date              2015-10-08 17:26:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e5f1bc63ad52d0eb86f7fb838226ca6036774660
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151008.182756
Firmware Date          Thu Oct  8 18:28:08 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device:Aries v2.5(Pass)
Build ID               20151008233852
Gaia Revision          e698df503ff700eb5782e3d50c6eb753567d3451
Gaia Date              2015-10-08 17:26:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/23b7f289df923c01e692299fcd4be7029de8b155
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151008.225742
Firmware Date          Thu Oct  8 22:57:51 UTC 2015
Bootloader             s1

Comment 16

[Carrie.Yang Leave from Mozilla]

Attachment: Verfied_Aries_v2.5.3gp