1210617 - (e10s/Private Browsing) Saving any PDF file via inside the build-in PDF viewer in a Private Window, creates the relevant entry in 'Downloads' in the Normal window instead

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Kostas]

Using FF 44.0a1 x64.

STR: (in a clean profile)
- launch Firefox: it will open a Normal window
- open a Private window and open any PDF file, eg http://www.cbu.edu.zm/downloads/pdf-sample.pdf
Now, as it's displayed in the build-in PDF viewer (and it's completely loaded), 
click the 'down arrow' button in the build-in viewer in order to download it . 
Observe that:
1. the 'down arrow' button remains pressed
2. the animation in the Downloads button doesn't appear: if you clicki the button, you see that there's no entry for that file in the panel.
- Now, switch to the Normal window and click on the Downloads button:
you'll see that the entry for the PDF file was added there, instead.


Pn the other hand, if you download the PDF file 
via rightclicking on the document in the build-in PDF viewer and pressing 'Save Page as' instead, 
then the issue doesn't occur.

Comment 1

[Kostas]

This issue only occurs with e10s enabled, i.e. in e10s windows.

Comment 2

[Josh Matthews [:jdm]]

This sounds very similar to bug 1199841.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Kostas: you filed this bug just a few days ago. Did you notice whether this is a recent regression, or you can't tell for sure? (i.e., you used to do this often in the past and it worked fine, even with e10s on)

Comment 4

[Kostas]

No, unfortunately I can't tell for sure.

Comment 5

[Jim Mathies [:jimm]]

felipe, were you going to pick this up?

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Yeah, and i'm hoping it's a dupe of bug 1199841, but we will see

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Attachment: fix-externalhandler-pbbrowsing

The problem is that ExternalHelperAppParent implements nsIChannel but not PrivateBrowsingChannel, which makes nsExternalAppHandler::RetargetLoadNotifications miss the pb status when calling NS_UsePrivateBrowsing.

Comment 8

[Jason Duell]

Comment on attachment 8682054 [details] [diff] [review]
fix-externalhandler-pbbrowsing

Review of attachment 8682054 [details] [diff] [review]:
-----------------------------------------------------------------

I think this should work.  I assume you've tested the patch manually?

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Yep I did, it works.  I'm assuming that there's nothing that needs to be changed here given the new patch in bug 8690005?

Comment 10

[:Felipe Gomes (needinfo for replies!)]

(In reply to :Felipe Gomes from comment #9)
> Yep I did, it works.  I'm assuming that there's nothing that needs to be
> changed here given the new patch in bug 8690005?

(Not sure how I came up with that number, but) I meant bug 1199841

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/bfd81e42d1dd

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bfd81e42d1dd

Comment 13

[Fahmida Noor]

I have reproduced this bug with Firefox Nightly 44.0a1 (Build Id : 20151001030236) on Windows 7(64-bit) with the instructions from comment 0.

Verified as fixed with Firefox Release 45.0.2 (Build ID : 20160407164938)

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0

[testday-20160415]