Closed Bug 1210660 Opened 4 years ago Closed 3 years ago

Change vp8 threshold for static images in screensharing mode

Categories

(Core :: WebRTC, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox44 --- wontfix
firefox49 --- fixed
firefox50 --- fixed
Blocking Flags:

People

(Reporter: jesup, Assigned: dminor)

Details

Attachments

(2 files)

https://code.google.com/p/webrtc/issues/detail?id=5015

This is for cherry-picking the patch into our tree to improve screensharing, especially for 'static' content like slides.
backlog: --- → webrtc/webaudio+
Rank: 25
Priority: -- → P2
Attached patch upstream patchSplinter Review
FYI, I checked to be sure and we do set kScreensharing in MediaPipelineFactory.cpp
Attachment #8668765 - Flags: review?(tterribe)
Attachment #8668765 - Flags: review?(tterribe) → review+
Assignee: rjesup → dminor
This changes the static threshold in screensharing mode and ensures that the
screensharing mode is in fact passed to the codec.

This also causes the peer connection to update the media pipelines when a track is
replaced to cause the codec to be notified that the source has changed and to
change settings appropriately. It seems to be a common use case to have a camera
track be replaced by a screenshare track during a call.

Review commit: https://reviewboard.mozilla.org/r/58974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58974/
Attachment #8762090 - Flags: review?(rjesup)
Status: NEW → ASSIGNED
Comment on attachment 8762090 [details]
Bug 1210660 - Change vp8 threshold for static images in screensharing mode;

https://reviewboard.mozilla.org/r/58974/#review55976
Attachment #8762090 - Flags: review?(rjesup) → review+
Comment on attachment 8762090 [details]
Bug 1210660 - Change vp8 threshold for static images in screensharing mode;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58974/diff/1-2/
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ff8e745ca48
Change vp8 threshold for static images in screensharing mode; r=jesup
https://hg.mozilla.org/mozilla-central/rev/0ff8e745ca48
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Randell -- Since Dan is on PTO, can you ask for uplift on this to Fx 49?
Flags: needinfo?(rjesup)
Comment on attachment 8762090 [details]
Bug 1210660 - Change vp8 threshold for static images in screensharing mode;

Approval Request Comment
[Feature/regressing bug #]: N/A

[User impact if declined]: greatly increased bandwidth use (or lower quality for other streams) when sharing static or mostly-static screens/windows/etc.

[Describe test coverage new/current, TreeHerder]: Manual testing.  Used upstream by Chrome; this is an port over of what they did.

[Risks and why]: extremely low risk; just bookkeeping to know if it's a screenshare, and a parameter adjustment to the encoder.

[String/UUID change made/needed]: none
Flags: needinfo?(rjesup)
Attachment #8762090 - Flags: approval-mozilla-aurora?
Comment on attachment 8762090 [details]
Bug 1210660 - Change vp8 threshold for static images in screensharing mode;

This patch improves the bandwidth when sharing static images. Take it in aurora.
Attachment #8762090 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.