Closed Bug 1210674 Opened 9 years ago Closed 8 years ago

use dialog service to show improve_browser_os_send_feedback dialogs

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
tracking-b2g backlog

People

(Reporter: gasolin, Assigned: ralin)

References

Details

(Whiteboard: [good first bug][mentor-lang=zh][lang=js])

Attachments

(2 files)

In improve firefox panel,

We'd use dialog service to show the dialog instead of current html dialog in improve_browser_os_send_feedback.html
Summary: use dialog service to show media storage dialogs → use dialog service to show improve_browser_os_send_feedback dialogs
could refer Bug 1203038 to replace HTML dialog with DialogService
Whiteboard: [good first bug][mentor-lang=zh][lang=js]
Assignee: nobody → ralin
Comment on attachment 8692324 [details] [review]
[gaia] raylin:1210674-improve-feedback-to-dialog-service > mozilla-b2g:master

Patch content:
1. Remove old dialog form from HTML
2. Replace alert & done dialog with Dialog Service
3. Update unit test

Thanks,
Attachment #8692324 - Flags: review?(gasolin)
Comment on attachment 8692324 [details] [review]
[gaia] raylin:1210674-improve-feedback-to-dialog-service > mozilla-b2g:master

Looks good, thanks!
Attachment #8692324 - Flags: review?(gasolin) → review+
https://github.com/mozilla-b2g/gaia/commit/603043edbefc3e2b3fefdf5432f11c88f3827267
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Please make sure all tests passed before landing...
Fixed problem on integration tests. All tests passed on both local and treeherder. Thanks.

Commit: https://github.com/mozilla-b2g/gaia/commit/5c79eeb800161651b22af9461e3de07e527a0141
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.