Closed
Bug 1210674
Opened 9 years ago
Closed 9 years ago
use dialog service to show improve_browser_os_send_feedback dialogs
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(tracking-b2g:backlog)
RESOLVED
FIXED
| tracking-b2g | backlog |
People
(Reporter: gasolin, Assigned: ralin)
References
Details
(Whiteboard: [good first bug][mentor-lang=zh][lang=js])
Attachments
(2 files)
In improve firefox panel,
We'd use dialog service to show the dialog instead of current html dialog in improve_browser_os_send_feedback.html
|
Reporter | |
Updated•9 years ago
|
tracking-b2g:
--- → backlog
|
|
Reporter | |
Updated•9 years ago
|
Summary: use dialog service to show media storage dialogs → use dialog service to show improve_browser_os_send_feedback dialogs
|
|
Reporter | |
Comment 1•9 years ago
|
||
could refer Bug 1203038 to replace HTML dialog with DialogService
Whiteboard: [good first bug][mentor-lang=zh][lang=js]
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ralin
|
||
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8692324 [details] [review]
[gaia] raylin:1210674-improve-feedback-to-dialog-service > mozilla-b2g:master
Patch content:
1. Remove old dialog form from HTML
2. Replace alert & done dialog with Dialog Service
3. Update unit test
Thanks,
Attachment #8692324 -
Flags: review?(gasolin)
|
|
Reporter | |
Comment 4•9 years ago
|
||
Comment on attachment 8692324 [details] [review]
[gaia] raylin:1210674-improve-feedback-to-dialog-service > mozilla-b2g:master
Looks good, thanks!
Attachment #8692324 -
Flags: review?(gasolin) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Comment 6•9 years ago
|
||
Reverted in https://github.com/mozilla-b2g/gaia/commit/a84c2dbe672583914d04380cd61a56f1c60c3b8e for Gij(15) bustage on b-i like this -> https://treeherder.mozilla.org/logviewer.html#?job_id=3555685&repo=b2g-inbound
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Comment 7•9 years ago
|
||
Please make sure all tests passed before landing...
|
|
||
Comment 8•9 years ago
|
||
|
|
Assignee | |
Comment 9•9 years ago
|
||
Fixed problem on integration tests. All tests passed on both local and treeherder. Thanks.
Commit: https://github.com/mozilla-b2g/gaia/commit/5c79eeb800161651b22af9461e3de07e527a0141
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•