1210717 - web storage event setattribute test unstable with e10s on linux

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[James Graham [:jgraham]]

Disabling for now

testing/web-platform/tests/webstorage/event_setattribute.html

Comment 1

[Ryan VanderMeulen [:RyanVM]]

This still fails on e10s. Can you please help find an owner, Andrew?

https://treeherder.mozilla.org/logviewer.html#?job_id=18236926&repo=try#L131152

14:53:21     INFO - TEST-START | /webstorage/event_setattribute.html
14:53:21     INFO - TEST-UNEXPECTED-FAIL | /webstorage/event_setattribute.html | sessionStorage mutations fire StorageEvents that are caught by the event listener attached via setattribute. - storageEventList[0] is undefined
14:53:21     INFO - step2@http://web-platform.test:8000/webstorage/event_setattribute.js:29:13
14:53:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
14:53:21     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1406:20
14:53:21     INFO - onTimeout@http://web-platform.test:8000/webstorage/eventTestHarness.js:22:13
14:53:21     INFO - setTimeout handler*countStorageEvents@http://web-platform.test:8000/webstorage/eventTestHarness.js:33:5
14:53:21     INFO - runAfterNStorageEvents@http://web-platform.test:8000/webstorage/eventTestHarness.js:13:5
14:53:21     INFO - step1@http://web-platform.test:8000/webstorage/event_setattribute.js:20:13
14:53:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
14:53:21     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1406:20
14:53:21     INFO - EventHandlerNonNull*step0@http://web-platform.test:8000/webstorage/event_setattribute.js:12:29
14:53:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
14:53:21     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1406:20
14:53:21     INFO - setTimeout handler*clearStorage@http://web-platform.test:8000/webstorage/eventTestHarness.js:40:9
14:53:21     INFO - @http://web-platform.test:8000/webstorage/event_setattribute.js:7:9
14:53:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
14:53:21     INFO - async_test@http://web-platform.test:8000/resources/testharness.js:513:13
14:53:21     INFO - @http://web-platform.test:8000/webstorage/event_setattribute.js:2:5
14:53:21     INFO - testStorages@http://web-platform.test:8000/webstorage/eventTestHarness.js:52:5
14:53:21     INFO - @http://web-platform.test:8000/webstorage/event_setattribute.js:1:1
14:53:21     INFO - TEST-UNEXPECTED-FAIL | /webstorage/event_setattribute.html | localStorage mutations fire StorageEvents that are caught by the event listener attached via setattribute. - assert_unreached: got at least 2, expected only 1 events Reached unreachable code
14:53:21     INFO - step2@http://web-platform.test:8000/webstorage/event_setattribute.js:26:17
14:53:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
14:53:21     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1406:20
14:53:21     INFO - onTimeout@http://web-platform.test:8000/webstorage/eventTestHarness.js:25:13
14:53:21     INFO - setTimeout handler*countStorageEvents@http://web-platform.test:8000/webstorage/eventTestHarness.js:33:5
14:53:21     INFO - runAfterNStorageEvents@http://web-platform.test:8000/webstorage/eventTestHarness.js:13:5
14:53:21     INFO - step1@http://web-platform.test:8000/webstorage/event_setattribute.js:20:13
14:53:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
14:53:21     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1406:20
14:53:21     INFO - EventHandlerNonNull*step0@http://web-platform.test:8000/webstorage/event_setattribute.js:12:29
14:53:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
14:53:21     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1406:20
14:53:21     INFO - setTimeout handler*clearStorage@http://web-platform.test:8000/webstorage/eventTestHarness.js:40:9
14:53:21     INFO - @http://web-platform.test:8000/webstorage/event_setattribute.js:7:9
14:53:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
14:53:21     INFO - async_test@http://web-platform.test:8000/resources/testharness.js:513:13
14:53:21     INFO - @http://web-platform.test:8000/webstorage/event_setattribute.js:2:5
14:53:21     INFO - testStorages/<@http://web-platform.test:8000/webstorage/eventTestHarness.js:57:13
14:53:21     INFO - Tests.prototype.notify_result/<@http://web-platform.test:8000/resources/testharness.js:1867:21
14:53:21     INFO - forEach@http://web-platform.test:8000/resources/testharness.js:2521:17
14:53:21     INFO - Tests.prototype.notify_result@http://web-platform.test:8000/resources/testharness.js:1864:9
14:53:21     INFO - Tests.prototype.result@http://web-platform.test:8000/resources/testharness.js:1858:9
14:53:21     INFO - Test.prototype.done@http://web-platform.test:8000/resources/testharness.js:1492:9
14:53:22     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1392:13
14:53:22     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1406:20
14:53:22     INFO - onTimeout@http://web-platform.test:8000/webstorage/eventTestHarness.js:22:13
14:53:22     INFO - setTimeout handler*countStorageEvents@http://web-platform.test:8000/webstorage/eventTestHarness.js:33:5
14:53:22     INFO - runAfterNStorageEvents@http://web-platform.test:8000/webstorage/eventTestHarness.js:13:5
14:53:22     INFO - step1@http://web-platform.test:8000/webstorage/event_setattribute.js:20:13
14:53:22     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
14:53:22     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1406:20
14:53:22     INFO - EventHandlerNonNull*step0@http://web-platform.test:8000/webstorage/event_setattribute.js:12:29
14:53:22     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
14:53:22     INFO - Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1406:20
14:53:22     INFO - setTimeout handler*clearStorage@http://web-platform.test:8000/webstorage/eventTestHarness.js:40:9
14:53:22     INFO - @http://web-platform.test:8000/webstorage/event_setattribute.js:7:9
14:53:22     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1382:20
14:53:22     INFO - async_test@http://web-platform.test:8000/resources/testharness.js:513:13
14:53:22     INFO - @http://web-platform.test:8000/webstorage/event_setattribute.js:2:5
14:53:22     INFO - testStorages@http://web-platform.test:8000/webstorage/eventTestHarness.js:52:5
14:53:22     INFO - @http://web-platform.test:8000/webstorage/event_setattribute.js:1:1
14:53:22     INFO - TEST-OK | /webstorage/event_setattribute.html | took 922ms

Comment 2

[Boris Zbarsky [:bzbarsky]]

That try push removed the failure annotations.  Why did it do that?  This test is currently expected to fail on all platforms, as far as I can tell; the e10s thing is unrelated to that.

Or put another way, what's needed here is a try push that removes just these 2 lines from the .ini:

  disabled:
    if e10s and (os == "linux"): https://bugzilla.mozilla.org/show_bug.cgi?id=1210717

and then retriggers some to make sure the test doesn't do anything other than what's annotated in the .ini.

Comment 3

[Boris Zbarsky [:bzbarsky]]

That said, the fact that this fails at all is because the test is buggy, in much the same way as bug 1225188 comment 2 described about a similar test in this directory.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: This is the patch to really push to try, I think

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Touche.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fcb0e45bf5f5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8734528 [details] [diff] [review]
This is the patch to really push to try, I think

Green on Try :)

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b359bd927f0f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b359bd927f0f