Closed Bug 1210755 Opened 4 years ago Closed 4 years ago

Switch to Android 6.0 SDK / API 23

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(3 files)

Patches for all build errors (meta bug 1183061) are landed or in review. This bug is tracking the work needed to actually switch to the new SDK.

Note that this bug is only about switching to the new SDK (and matching build tools) and not about setting targetSdkVersion to 23. This will require more work and this is tracked by meta bug 1207194.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Comment on attachment 8668931 [details] [diff] [review]
Gradle build: Compile with SDK version 23 and use build tools 23.0.1

Review of attachment 8668931 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.
Attachment #8668931 - Flags: review?(nalexander) → review+
Comment on attachment 8668934 [details] [diff] [review]
Mach build: Compile with SDK version 23 and use build tools 23.0.1

Review of attachment 8668934 [details] [diff] [review]:
-----------------------------------------------------------------

Fire the missiles!

::: python/mozboot/mozboot/android.py
@@ +20,5 @@
>  # These are the "Android packages" needed for building Firefox for Android.
>  # Use |android list sdk --extended| to see these identifiers.
>  ANDROID_PACKAGES = [
>      'tools',
>      'platform-tools-preview', # Temporarily, tools depends on platform-tools-preview.

Is this still accurate?  I wonder if we're back to platform-tools?
Attachment #8668934 - Flags: review?(nalexander) → review+
(In reply to Nick Alexander :nalexander from comment #4)
> Is this still accurate?  I wonder if we're back to platform-tools?

Oh yeah, definitely. I'll look at that in a follow-up patch.
Try build with new releng.manifest (Still building with API 22):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=84676097c3fe

Try build with new releng.manifest (Building with API 23 and all build patches applied):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=77838246b41a

Let's see how this turns out. :)
(In reply to Sebastian Kaspari (:sebastian) from comment #7)
> Try build with new releng.manifest (Still building with API 22):
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=84676097c3fe
> 
> Try build with new releng.manifest (Building with API 23 and all build
> patches applied):
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=77838246b41a
> 
> Let's see how this turns out. :)

All green \o/
leave-open: I'm going to add a patch for 'platform-tools-preview'.
https://hg.mozilla.org/mozilla-central/rev/8e6e5ca973d9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 44 → mozilla44
You need to log in before you can comment on or make changes to this bug.