1210755 - Switch to Android 6.0 SDK / API 23

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Patches for all build errors (meta bug 1183061) are landed or in review. This bug is tracking the work needed to actually switch to the new SDK.

Note that this bug is only about switching to the new SDK (and matching build tools) and not about setting targetSdkVersion to 23. This will require more work and this is tracked by meta bug 1207194.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Gradle build: Compile with SDK version 23 and use build tools 23.0.1

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Mach build: Compile with SDK version 23 and use build tools 23.0.1

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8668931 [details] [diff] [review]
Gradle build: Compile with SDK version 23 and use build tools 23.0.1

Review of attachment 8668931 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8668934 [details] [diff] [review]
Mach build: Compile with SDK version 23 and use build tools 23.0.1

Review of attachment 8668934 [details] [diff] [review]:
-----------------------------------------------------------------

Fire the missiles!

::: python/mozboot/mozboot/android.py
@@ +20,5 @@
>  # These are the "Android packages" needed for building Firefox for Android.
>  # Use |android list sdk --extended| to see these identifiers.
>  ANDROID_PACKAGES = [
>      'tools',
>      'platform-tools-preview', # Temporarily, tools depends on platform-tools-preview.

Is this still accurate?  I wonder if we're back to platform-tools?

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Nick Alexander :nalexander from comment #4)
> Is this still accurate?  I wonder if we're back to platform-tools?

Oh yeah, definitely. I'll look at that in a follow-up patch.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Update releng.manifest to use latest SDK and tools

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Try build with new releng.manifest (Still building with API 22):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=84676097c3fe

Try build with new releng.manifest (Building with API 23 and all build patches applied):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=77838246b41a

Let's see how this turns out. :)

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sebastian Kaspari (:sebastian) from comment #7)
> Try build with new releng.manifest (Still building with API 22):
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=84676097c3fe
> 
> Try build with new releng.manifest (Building with API 23 and all build
> patches applied):
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=77838246b41a
> 
> Let's see how this turns out. :)

All green \o/

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f3cb1dd809ff

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Last sanity check before I push everything:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca73de452e8

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4fc76c102375
https://hg.mozilla.org/integration/fx-team/rev/a51020a4a9c2
https://hg.mozilla.org/integration/fx-team/rev/88829b86c9eb

Comment 12

[Sebastian Kaspari (:sebastian; :pocmo)]

leave-open: I'm going to add a patch for 'platform-tools-preview'.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f3cb1dd809ff

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4fc76c102375
https://hg.mozilla.org/mozilla-central/rev/a51020a4a9c2
https://hg.mozilla.org/mozilla-central/rev/88829b86c9eb

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8e6e5ca973d9

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8e6e5ca973d9