1210775 - Modify Last Synced setting row to have 'Last Synced' and timestamp label on two separate lines

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stephan Leroux [:sleroux]]

As a solution for locales where Last Sycned + timestamp are really long, we want to have the two labels on separate lines with the cell height adjusted to accommodate the second label. See https://bugzilla.mozilla.org/show_bug.cgi?id=1183905#c23 for more details.

Comment 1

[Stefan Plewako [:stef]]

Maybe something like for Close Private Tabs / When Leaving Private Browsing two lines would be better?

Comment 2

[Stephan Leroux [:sleroux]]

We're going with something similar - just the two lines on the right instead of the left:

https://bugzilla.mozilla.org/attachment.cgi?id=8665643&action=edit

Comment 3

[Stefan Plewako [:stef]]

(In reply to Stefan Plewako [:stef] from comment #1)
> Maybe something like for Close Private Tabs / When Leaving Private Browsing
> two lines would be better?

(In reply to Stephan Leroux [:sleroux] from comment #2)
> We're going with something similar - just the two lines on the right instead
> of the left

Are we sure? https://bug1183905.bmoattachments.org/attachment.cgi?id=8665643 looks rather unusual and inconsistent with "When Leaving Private Browsing".

Comment 4

[Stephan Leroux [:sleroux]]

Clearing NI for Robin as we've discussed this in triage.

We're going to remove the 'Last Synced' label and just show the timestamp as the time will implicitly let the user know the 'last' synced time. The row will look like this:

Sync Now              Just now (or whatever the timestamp is)

Comment 5

[me]

Attachment: Pull request

Comment 6

[Stephan Leroux [:sleroux]]

Comment on attachment 8678940 [details] [review]
Pull request

Code looks good - thanks for the patch! 

:tecgirl, do we want to keep the the text for these lower cased? If want to change it we'll need to push this to 2.0 since 1.1.1 will be bug fix only :\

Comment 7

[Robin Andersen [:tecgirl]]

Comment on attachment 8678940 [details] [review]
Pull request

I'll be honest, dropping "Last synced: xx" makes the other part of the string rather anemic, it lacks context. I'm tempted to drop it all until we can come to a better solution.

Two examples, http://c.tecgirl.com/ddR4 & http://c.tecgirl.com/dddB

If we were to capitalize it, it would show:
 "Sync Now          Just Now"
 "Sync Now          Last Week"

It's weird if we capitalize it or not.

Comment 8

[Robin Andersen [:tecgirl]]

Darrin, can I get your thoughts on this?

Comment 9

[Darrin Henein [:darrin]]

Honestly, I think if it were capitalized it will look fine. If we come up with a better solution in the future, we can ship that, but in the event that we don't come back to this for a while, something is better than nothing.

If we don't want to change the strings and land this now, can we always show the timestamp (instead of the fancy "Just now" strings) and then show those strings 2.0+?

Thoughts?

Comment 10

[Stephan Leroux [:sleroux]]

We can show a timestamp using a date formatter like YYYY/MM/DD HH:mm:ss for now if we wanted for 1.2.

Comment 11

[Robin Andersen [:tecgirl]]

I would greatly prefer that. I'm not thrilled with the current state at all.

Comment 12

[Bryan Munar (:bkmunar)]

Attachment: PR - timestamp

Comment 13

[Bryan Munar (:bkmunar)]

Comment on attachment 8705368 [details]
PR - timestamp

>https://github.com/mozilla/firefox-ios


https://github.com/mozilla/firefox-ios/pull/1416

Comment 14

[Stephan Leroux [:sleroux]]

Comment on attachment 8705368 [details]
PR - timestamp

Looks good - just some nits/comments on the PR.