Closed Bug 1210804 Opened 9 years ago Closed 9 years ago

loadDataAdapterScript fails silently if script not found

Categories

(Firefox OS Graveyard :: Sync, defect)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: mbdejong, Assigned: mbdejong)

References

Details

If you enable sync for 'passwords' (for which DataAdapter has not landed yet), bootstrap.js will fail silently. Should display/return a meaningful error message instead.
Assignee: nobody → mbdejong
Blocks: 1195647
I filed bug 1210473 to avoid this situation. But it's good to have the Sync app ready for this as well.
Even though we are in full control of making sure we never get a file-not-found error at runtime, would be nice to fix.

I'll see if I can refactor LazyLoader.load to be properly Promise-y and reject (instead of throwing an error, as it does now) if the file is not found.

And then I could fix the MockLazyLoader at the same time, which is bug 1181687.
This run-time check is not necessary if we make sure we load the right files, and test for that.

MockLazyLoader fix has been merged, so we can now properly test all the filenames that need to be loaded, in unit tests.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.