1210824 - ADB pull from B2G Installer broken

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[:gerard-majax]

After updating ADB Helper and Gecko to latest nightly of today, B2G Installer addon is unable to pull anything from device:

> Devices._devices["0d38fb1e0c599f53"].pull("/fstab.hammerhead", "/tmp/b2g-installer/hammerhead/blobs/fstab.hammerhead").then(v => { console.debug(v); }, e => { console.debug(e); });
> Object { , 1 de plus… }
> BAD_RESPONSE

> Devices._devices["0d38fb1e0c599f53"].pull("/system/bin/bridgemgrd", "/tmp/b2g-installer/hammerhead/blobs/system/bin/bridgemgrd").then(v => { console.debug(v); }, e => { console.debug(e); });
> Object { , 1 de plus… }
> BAD_RESPONSE

Both can be pulled by hand from CLI.

Comment 1

[:gerard-majax]

Attachment: debug log

Comment 2

[:gerard-majax]

Any help?

Comment 3

[:gerard-majax]

https://github.com/mozilla/adbhelper/commit/95cf54f3ca8ef5667655bcb9fcc0451431bfa063#diff-369a5f292b913be569e8eafd45b090baL279
https://github.com/mozilla/adbhelper/commit/95cf54f3ca8ef5667655bcb9fcc0451431bfa063#diff-369a5f292b913be569e8eafd45b090baL279
> _checkResponse: function adb_checkResponse(aPacket, expected) {
...
> return view[0] == expected;

This was called by: (!client.checkResponse(aData, STAT))

Now we have from adb-client.js:
> function checkResponse(aPacket) {
...
> return view[0] == OKAY;

So the second parameter is not even used.

Comment 4

[:gerard-majax]

Attachment: ADB Helper PR

That fixes the improper response checking.

Comment 5

[:gerard-majax]

Attachment: New errors after fixing checkResponse()

Comment 6

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #5)
> Created attachment 8668996 [details]
> New errors after fixing checkResponse()

Added debug:
> ADB Addon Helper: fileData.set(pkgData, 0);

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I've got a complete fix, will post my own PR.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Repair pull / push for Gecko 43+

Comment 9

[:gerard-majax]

Great! I'll test this locally :).

Comment 10

[:gerard-majax]

Comment on attachment 8669112 [details] [review]
Repair pull / push for Gecko 43+

Looks like it fixes the issue on my side too! Thanks!

Comment 11

[Alexandre Poirot [:ochameau]]

Comment on attachment 8669112 [details] [review]
Repair pull / push for Gecko 43+

Good catch, Thanks!

Comment 12

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Merged: https://github.com/mozilla/adbhelper/commit/f662242e08f00995434d752f788d21a1b344d65a

Will start preparing 0.8.2 release.

Comment 13

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

0.8.2 released.  May take up to 24 hours to appear available.