Closed Bug 1210857 Opened 6 years ago Closed 6 years ago

Intent URIs may throw SecurityException

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: mcomella, Assigned: rchawla, Mentored)

References

Details

Specifically intent URIs from web content.

By trying to explicitly open an Android activity to which we don't have access, a SecurityException may be thrown.

Verify and fix this!
Mentor: michael.l.comella, ally
The way to fix this, I think, would be to catch the security exception from the calling startActivity code – which is likely in GeckoAppShell.openUriExternal or IntentHelper.open*.
If this is assigned to no one, I would like to take this up. I am new to this project.
Great! Let your mentors know in this bug if you need any more advice. Comment 1 seems to have most of what you'd need.
Assignee: nobody → rchawla
Status: NEW → ASSIGNED
(In reply to Michael Comella (:mcomella) from comment #1)
> The way to fix this, I think, would be to catch the security exception from
> the calling startActivity code – which is likely in
> GeckoAppShell.openUriExternal or IntentHelper.open*.

Intent URIs are started in ActivityHandleHelper.startIntentAndCatch(), which handles the Security Exception. Seems like the issue has already been resolved, or I am looking at the wrong thing. Can you provide more details?
Flags: needinfo?(michael.l.comella)
(In reply to rchawla from comment #4)
> Intent URIs are started in ActivityHandleHelper.startIntentAndCatch(), which
> handles the Security Exception. Seems like the issue has already been
> resolved, or I am looking at the wrong thing. Can you provide more details?

It seems that you are correct – the issue is already solved. We don't catch the SecurityExceptions on the ActivityHelperHandler.startIntentForActivity case but we don't happen to call it from Intent URIs (for now) so the Intents should be well formed.

Sorry about that! If you're looking for something else to work on, perhaps bug 1223586 or bug 1212032? Let me know if want some more options.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: needinfo?(michael.l.comella)
Resolution: --- → WORKSFORME
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.