Closed
Bug 1210879
Opened 9 years ago
Closed 9 years ago
Remove the unused #category-searchengine and category-searchengines.png
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: jaws, Assigned: hanue, Mentored)
Details
(Whiteboard: [good first bug])
Attachments
(2 files)
4.81 KB,
patch
|
jaws
:
feedback+
|
Details | Diff | Splinter Review |
5.40 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
We have CSS defined for #category-searchengine in extensions.inc.css as well as an icon file named category-searchengines.png that are unused/inaccessible from both Firefox and Thunderbird. We can remove these from the source tree. http://mxr.mozilla.org/comm-central/search?string=category-searchengine&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
Comment 1•9 years ago
|
||
I'd love to work on this! I've assigned it to myself it that's ok.
Assignee: nobody → ma.steiman
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•9 years ago
|
||
Great, thanks for working on it :)
Comment 3•9 years ago
|
||
Since Thunderbird is comm-central does there need to be 2 separate patch files? I've never submitted a patch for both Firefox and Thunderbird code...
Flags: needinfo?(jaws)
Comment 4•9 years ago
|
||
I'm having some serious network troubles :\ I took myself off in case someone wants to go ahead and work on this. Sorry!
Assignee: ma.steiman → nobody
Status: ASSIGNED → NEW
Assignee | ||
Comment 5•9 years ago
|
||
Hello there! Could you please assign me this bug? Thank you for your time and consideration.
Reporter | ||
Comment 6•9 years ago
|
||
I prefer to wait to assign a bug until a patch is attached. Eduard, please go ahead and work on the bug :)
Flags: needinfo?(jaws)
Assignee | ||
Comment 7•9 years ago
|
||
Please find attached my patch.
Attachment #8675853 -
Flags: review?(jaws)
Reporter | ||
Comment 8•9 years ago
|
||
Comment on attachment 8675853 [details] [diff] [review] rev1 - Remove CSS and .png file references Review of attachment 8675853 [details] [diff] [review]: ----------------------------------------------------------------- Please also delete the category-searchengines.png file. You should use `hg remove category-searchengines.png` in the directories where it is found to remove it from Mercurial.
Attachment #8675853 -
Flags: review?(jaws) → feedback+
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → hanue
Status: NEW → ASSIGNED
Assignee | ||
Comment 9•9 years ago
|
||
Please find attached the updated patch.
Attachment #8681640 -
Flags: review?(jaws)
Comment 10•9 years ago
|
||
Comment on attachment 8681640 [details] [diff] [review] rev2 - Remove .png files Nice, thank you!
Attachment #8681640 -
Flags: review?(jaws) → review+
Comment 12•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/944701d4ab99
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•