1210944 - Return a promise in BackgroundPageThumbs.captureIfMissing

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Olivier Yiptong [:oyiptong]]

For the remote newtab page, in order for the privileged context to return a thumbnail when it's ready, we want captureIfMissing in BackgroundPageThumbs to return a promise.

It is used in the RemoteAboutNewTab module in bug 1210940.

Comment 1

[Olivier Yiptong [:oyiptong]]

Attachment: bug_1210944.patch

Comment 2

[Olivier Yiptong [:oyiptong]]

try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a719446ee7bc

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 8669124 [details] [diff] [review]
bug_1210944.patch

Review of attachment 8669124 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.  Could you please use Task.async instead of returning a promise?

Comment 4

[Marcos Caceres [:marcosc]]

Olivier, I'll fix this one up.

Comment 5

[Marcos Caceres [:marcosc]]

Attachment: Using Task.js makes code a bit cleaner.

Comment 6

[Marcos Caceres [:marcosc]]

Attachment: Fixed a bug that was preventing tests from passing

Comment 7

[Olivier Yiptong [:oyiptong]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/334b49fa6913dcd46bea7d5cd86698d5f666c20d
Bug 1210944 - Return a promise in BackgroundPageThumbs.captureIfMissing. r=adw

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/334b49fa6913