Closed Bug 1210944 Opened 8 years ago Closed 8 years ago

Return a promise in BackgroundPageThumbs.captureIfMissing

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Version:
40 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 44
Iteration:
44.2 - Oct 19
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: oyiptong, Assigned: marcosc)

References

Details

Attachments

(1 file, 2 obsolete files)

Fixed a bug that was preventing tests from passing
2.02 KB, patch
Details | Diff | Splinter Review 
For the remote newtab page, in order for the privileged context to return a thumbnail when it's ready, we want captureIfMissing in BackgroundPageThumbs to return a promise.

It is used in the RemoteAboutNewTab module in bug 1210940.
Attached patch bug_1210944.patch (obsolete) — — Splinter Review 

        Attachment #8669124 -
        Flags: review?(adw)

    
  
Assignee: nobody → oyiptong

    
    

    
  
Comment on attachment 8669124 [details] [diff] [review]
bug_1210944.patch

Review of attachment 8669124 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.  Could you please use Task.async instead of returning a promise?

        Attachment #8669124 -
        Flags: review?(adw) → review+

    
  
Assignee: oyiptong → mcaceres

    
    

    
  
Olivier, I'll fix this one up.

    
    

    
  


  

        Attachment #8669124 -
        Attachment is obsolete: true

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/334b49fa6913
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox44:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44

          You need to log in
          before you can comment on or make changes to this bug.