1211019 - [TaskManager] After choosing an app, that app should become frontmost in the stack.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Marcus Cavanaugh [:mcav]]

STR:

1. Open Task Manager with multiple apps open.

2. Tap on any app that's not the top of the stack.

3. Go back into task manager; you'll see that the stack still shows your app in the same (previous) position it was, because StackManager doesn't reorder the stack unless you actually go "home" first. (This behavior has not changed.)

4. Open a new sheet. As you're doing so, you'll see the cards reshuffle to match the new stack order.

We should do one of two things:

- Either don't show the visible shuffle on the way out, leaving the current StackManager behavior as-is, or

- Change the StackManager to always reshuffle the stack to place the "current" app at the rightmost position whenever you open it. (This is what iOS does; not sure about Android.)

Comment 1

[Marcus Cavanaugh [:mcav]]

Just met with Francis, who says that we should be reshuffling the stack every time an app becomes frontmost; so we should update StackManager to reshuffle as soon as we've chosen an app in Task Manager.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] mcav:stack-manager-cardviewclosed > mozilla-b2g:master

Comment 3

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8669222 [details] [review]
[gaia] mcav:stack-manager-cardviewclosed > mozilla-b2g:master

With this patch, the app chosen when exiting TaskManager is moved to the top of the stack; Francis confirmed that this is the desired behavior. (Currently, the app is not moved to the top of the stack.)

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8669222 [details] [review]
[gaia] mcav:stack-manager-cardviewclosed > mozilla-b2g:master

Looking good, apart from the edge gesture issue mentioned on github.

It's a bit weird to me that the cardview will always open on the last card, with the last used app, *except* if you used edge gestures.
Flagging Francis to check what is the expected behavior here.

Also wouldn't mind a small new integration test :)
(asserting on the card order between 2 card view use)

Comment 5

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8669222 [details] [review]
[gaia] mcav:stack-manager-cardviewclosed > mozilla-b2g:master

This patch addresses your homescreen comment and adds a coupple more tests: it updates the swipe-back-and-forth test to check for the proper top card, and a couple unit tests to verify the behavior of the homescreen change.

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8669222 [details] [review]
[gaia] mcav:stack-manager-cardviewclosed > mozilla-b2g:master

Perfect, thanks!

Comment 7

[Marcus Cavanaugh [:mcav]]

Since there are UI glitches without this patch as described in Comment 0 and Francis has stated that the patched behavior is desired, I've gone ahead and landed this. The needinfo? on Francis is still valid.

master: https://github.com/mozilla-b2g/gaia/commit/8c885615355b39de4b74903efabc603e6f32a915