1211221 - Error in parsing value for 'margin-bottom' after substituting variables. Falling back to 'initial'.

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Offending CSS in browser/themes/windows/browser.css:

> #TabsToolbar {
>   min-height: 0;
>   padding: 0;
>   margin-bottom: calc(-1 * var(--tab-toolbar-navbar-overlap)); /* overlap the nav-bar's top border */
> }

Seen on a local build of fx-team with tip of 3d5175374d15 on Windows 10.

Comment 1

[:Gijs (he/him)]

Does this go away if you add "px" here:

https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#2016

? (or remove 'px' from the similar definition in the devedition theme, if you're using that - it's not clear from your report!)

It would be quite helpful if the error message from the CSS actually included the string that broke things...

(I'd also argue that either 0 or 1px should work here, but IIRC calc() doesn't like completely unitless things, see also bug 956573 and bug 594933)

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Yeah that fixes it for me, and sorry, I should have said it but I'm not using the devtheme.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to :Gijs Kruitbosch from comment #1)
> It would be quite helpful if the error message from the CSS actually
> included the string that broke things...

Filed bug 1211479 for this.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

[Tracking Requested - why for this release]: The patch for bug 1190462 got uplifted to Firefox 42 and 43. We should get this uplifted along with it.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8669701 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1190462
[User impact if declined]: The TabsToolbar and NavBar will not visually blend correctly.
[Describe test coverage new/current, TreeHerder]: manual visual verification, simple patch
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e2b1303c3924

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e2b1303c3924

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8669701 [details] [diff] [review]
Patch

Easy fix, should be in 42 beta 5.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/928f4a4cf0f3

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4ca3cf497e6c