Closed Bug 1211221 Opened 4 years ago Closed 4 years ago

Error in parsing value for 'margin-bottom' after substituting variables. Falling back to 'initial'.

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox42 + fixed
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

Offending CSS in browser/themes/windows/browser.css:

> #TabsToolbar {
>   min-height: 0;
>   padding: 0;
>   margin-bottom: calc(-1 * var(--tab-toolbar-navbar-overlap)); /* overlap the nav-bar's top border */
> }

Seen on a local build of fx-team with tip of 3d5175374d15 on Windows 10.
Flags: needinfo?(bgrinstead)
Does this go away if you add "px" here:

https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#2016

? (or remove 'px' from the similar definition in the devedition theme, if you're using that - it's not clear from your report!)

It would be quite helpful if the error message from the CSS actually included the string that broke things...

(I'd also argue that either 0 or 1px should work here, but IIRC calc() doesn't like completely unitless things, see also bug 956573 and bug 594933)
Flags: needinfo?(bgrinstead) → needinfo?(jaws)
Attached patch PatchSplinter Review
Yeah that fixes it for me, and sorry, I should have said it but I'm not using the devtheme.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Attachment #8669701 - Flags: review?(gijskruitbosch+bugs)
(In reply to :Gijs Kruitbosch from comment #1)
> It would be quite helpful if the error message from the CSS actually
> included the string that broke things...

Filed bug 1211479 for this.
Attachment #8669701 - Flags: review?(gijskruitbosch+bugs) → review+
Blocks: 1190462
No longer blocks: 1091001
[Tracking Requested - why for this release]: The patch for bug 1190462 got uplifted to Firefox 42 and 43. We should get this uplifted along with it.
Comment on attachment 8669701 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1190462
[User impact if declined]: The TabsToolbar and NavBar will not visually blend correctly.
[Describe test coverage new/current, TreeHerder]: manual visual verification, simple patch
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8669701 - Flags: approval-mozilla-beta?
Attachment #8669701 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/e2b1303c3924
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8669701 [details] [diff] [review]
Patch

Easy fix, should be in 42 beta 5.
Attachment #8669701 - Flags: approval-mozilla-beta?
Attachment #8669701 - Flags: approval-mozilla-beta+
Attachment #8669701 - Flags: approval-mozilla-aurora?
Attachment #8669701 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.