1211252 - Autophone - Unit Test not (un)installing robocop.apk

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Starting with Bug 1200343 the rca test began failing with:

TEST-UNEXPECTED-FAIL | testAdobeFlash | Exception caught - java.lang.NoSuchMethodError: org.mozilla.gecko.GeckoEvent.createPreferencesGetEvent

This was not a regression due to the check in but was apparently due to an out of date version of robocop.apk. I uninstalled it manually on the devices, but then began to get exceptions when running rca which said 

0 ERROR runApp() exited with code 1
Unable to retrieve log file (/storage/sdcard0/tests/logs/mochitest.log) from remote device
1 ERROR Automation Error: Exception caught while running tests
Traceback (most recent call last):
  File "mochitest/runrobocop.py", line 454, in runSingleTest
    log_result = self.parseLocalLog()
  File "mochitest/runrobocop.py", line 270, in parseLocalLog
    with open(self.localLog) as currentLog:
IOError: [Errno 2] No such file or directory: 'robocop.log'

This was resolved by manually installing robocop.apk but there must be a bug where robocop.apk is not installed or uninstalled properly by tests/runtestsremote.py.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1211252-robocop-installation-v1.patch

Check that robocop.apk is installed before attempting to uninstall it, and check that the test name begins with robocoptest instead of testing for equality.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8672639 [details] [diff] [review]
bug-1211252-robocop-installation-v1.patch

Review of attachment 8672639 [details] [diff] [review]:
-----------------------------------------------------------------

this is nice- good idea to be safe!

Comment 3

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/d3674e56cdbd2903ba69f10bf0f04f33ed439840