1211255 - Downloads don't show up in download manager on Fennec

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Jan Henning [:JanH]]

After starting a download, it doesn't show up in the download manager any more.
If I have the download manager open while starting a download, it shows up, but if I later close and then re-open it, the download is missing again.

The regression window points to bug 1009795:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=10a4c5fbcca7d515fa287f89892fdd4c5e9a243e&tochange=cb7008d633835fa982492646de3cc191293fc28a

After having completed a new download and opening the download manager, the following error appears in the console:
> 14:25:32.345 Intl is not defined1 DownloadUtils.jsm:486:0

Comment 1

[:Gijs (out for now; he/him)]

[Tracking Requested - why for this release]:
Broken download things in Fennec


Ehsan, should this have used typeof instead?

Nick, why did tests not catch this? :-(

Comment 2

[Nick Alexander :nalexander [he/him]]

> Nick, why did tests not catch this? :-(

Was this intended for me?  I haven't any specific knowledge of this code, or the tests surrounding it.

Comment 3

[:Gijs (out for now; he/him)]

(In reply to Nick Alexander :nalexander from comment #2)
> > Nick, why did tests not catch this? :-(
> 
> Was this intended for me?  I haven't any specific knowledge of this code, or
> the tests surrounding it.

Yes. I was assuming we have automated tests for downloading files on Fennec. Do we not? Is that hard for some reason? It sounds like we should have tests (quite independent of DownloadUtils.jsm itself).

Comment 4

[Marco Bonardo [:mak]]

ugh, yeah, a typeof check would be better there, sorry for not catching that.

Comment 5

[:Gijs (out for now; he/him)]

Attachment: Trivial patch

I tested this on my local android device, and it does make downloads show up again.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Recent regression, tracking. We want to fix in 42.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9c7b48221853

Comment 8

[:Gijs (out for now; he/him)]

Comment on attachment 8669625 [details] [diff] [review]
Trivial patch

Approval Request Comment
[Feature/regressing bug #]: l10n fix to downloads code
[User impact if declined]: broken about:downloads / download manager on fennec
[Describe test coverage new/current, TreeHerder]: tests on desktop but apparently not on fennec...
[Risks and why]: one-line JS change that's pretty low-risk. Can't get any worse than totally busted!
[String/UUID change made/needed]: nope

Comment 10

[(no longer active)]

Sorry for the bustage and thanks for the quick fix, Gijs.

/me will learn js some day...  :/

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9c7b48221853

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8669625 [details] [diff] [review]
Trivial patch

Sure, we want it! Should be in 42 beta 6.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f17a4df0e817

Comment 14

[Jan Henning [:JanH]]

Verified with today's Nightly (build 20151008030232).

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/203920998d74

Comment 16

[u421692]

Verified as fixed on latest Aurora and Firefox 42 Beta 6.