Open Bug 1211332 Opened 9 years ago Updated 2 years ago

Avoid writing "local" variables to global object in property_database.js

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

Tracking Status
firefox44 --- affected

People

(Reporter: dholbert, Unassigned)

Details

Quoting heycam from bug 1210905:
==============
I just realised we probably shouldn't be writing local variables like "prop", "entry', "aliasTargetEntry", etc. on to the global object, but there is a bit of that in property_database.js already.  Mind filing a bug to wrap bits of property_database.js into a (function() { ... })()?

(Using "let" might be an option, too, although I see at least one variable declared at the top level that we probably don't want to expose to tests, which "let" wouldn't help with according to my reading of https://groups.google.com/forum/#!searchin/mozilla.dev.platform/changes$20in$20chrome$20js$20code/mozilla.dev.platform/XoW35OxqDYI/hyBtAzaoAwAJ.)
==============
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.