1211348 - Don't restore private tabs after killing the app if "Close Private tabs when leaving private browsing" is enabled

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Catalin Suciu [:csuciu]]

1. Go to Firefox settings and enable "Close Private tabs when leaving private browsing". 
2. Open a few private tabs
2. Kill Firefox from the app switcher
3. Open Firefox

Expected: The private tabs should not be restored because the user is leaving private browsing when Firefox is closed

Actual: The private tabs are restored

Comment 1

[Stephan Leroux [:sleroux]]

Not sure if we want to do this. Chrome doesn't close the tabs when the app is backgrounded and keep them open. I think the experience would be too jarring for the user to come back to the app and have everything change. For example, if the user was in a private tab and they come back from being backgrounded, what do we show?

Comment 2

[Stephan Leroux [:sleroux]]

Not sure if this is something we want to address for 2.0? Adding :tecgirl as well.

Comment 3

[Richard Newman [:rnewman]]

Maybe remove this option and leave PB mode instead?

Comment 4

[Robin Andersen [:tecgirl]]

Leave the setting, kill the tabs—if we indeed can tell the difference between a crash and a hard kill. If crash, offer to restore with dialog on next session. Do not offer to restore on kill.

Comment 5

[Robin Andersen [:tecgirl]]

On crash with "Close Private tabs when leaving private browsing" enabled:


Oops! Firefox crashed
Would you like to restore your private tabs?

[YES][NO]

Comment 6

[Stephan Leroux [:sleroux]]

Would we show this as an additional dialog after the current 'Restore Tabs' after a crash one? If "Close Private tabs when leaving private browsing" is disabled, we should restore all tabs and if it is enabled we show the 'Restore Private Tabs' one as well?

Comment 7

[Robin Andersen [:tecgirl]]

(In reply to Stephan Leroux [:sleroux] from comment #6)
> Would we show this as an additional dialog after the current 'Restore Tabs'
> after a crash one? If "Close Private tabs when leaving private browsing" is
> disabled, we should restore all tabs and if it is enabled we show the
> 'Restore Private Tabs' one as well?

My assumption is that we're providing this prompt in case it's one of the tabs causing the crash, correct?
Are we able to determine which tab caused the crash?
If so, then we should not load that tab and load the rest automatically, and prompt for Private tabs.

If not, then no, two dialogs is too much. Prompt to restore normal tabs. If they have the option to Close Private tabs enabled then kill those tabs. An expectation of loss should be apparent.

Comment 8

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 9

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/f04a94ea636ea596ddae3533e73aafc2b461d251

Landed on v10.x:

https://github.com/mozilla-mobile/firefox-ios/commit/d47275d36a78a39cf2562c91a4d5a5878f4c4691

Comment 10

[Simon Basca [:SimonB]]

Verifying as fix on master 9653a62c5 & 10.0(7233).