1211352 - [e10s][IMM] composition string on windowless plugin should be positioned at left-bottom of the plugin

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

In e10s mode, we don't cache editor rect (windowless plugin rect) in ContentCacheInParent. Therefore, IMMHandler cannot set the composing window to the left-bottom of the plugin rect.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=750c72c13a79

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.1 IMEContentObserver should be created when a plugin has focus

The main purpose of this fix is, the focused plugin rect is cached in ContentCacheInParent as focused editor rect. For that, we need to send the rect at:
* a plugin gets focus
* the plugin is scrolled or window moved
For computing the plugin rect, we need to use eQueryEditorRect at enough safe time. So, using IMEContentObserver should be the best approach.

My plan is, while a plugin has focus, IMEContentObserver should be created without nsIEditor. And it should notify widget of focus, blur and position change.

This patch allows to create IMEContentObserver instance when input context's IME enabled state is 'PLUGIN'.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 PuppetWidget shouldn't send notifications which are not wanted by the parent process

PuppetWidget shouldn't send ContentCache as a notification if it's not wanted by the parent process's widget. And TabParent doesn't need to check it. At text change notification, we've already used this approach.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.3 nsIWidget::GetIMEupdatePreference() for each platform should not request any notifications while a plugin has focus

For reducing unnecessary run-time cost, i.e., preventing notifications from content while a plugin has focus, all native IME handlers should return nsIMEUpdatePreference() when the IME enabled state of the input context is PLUGIN.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.4 PuppetWidget::GetIMEUpdatePreference() should request only position change notifications while a plugin has focus

While a plugin has focus, only PuupetWidget should request position change notification for updating the ContentCacheInParent::mEditorRect.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.5 PuppetWidget should cache only the focused editor rect information while a plugin has focus

PuppetWidget should ignore unnecessary notification with outputting warnings. Except not outputting warnings part, this change just makes the code safer.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ad1b9d9aae9

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e889d9abef34debbb7d09b4e187047bf2febece8
Bug 1211352 part.1 IMEContentObserver should be created when a plugin has focus r=smaug

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6fbe14c354aac2711fbd71df40c70901557da03
Bug 1211352 part.2 PuppetWidget shouldn't send notifications which are not wanted by the parent process r=m_kato

https://hg.mozilla.org/integration/mozilla-inbound/rev/4724d4f02b571d73c3571823b53c3ed97794466a
Bug 1211352 part.3 nsIWidget::GetIMEupdatePreference() for each platform should not request any notifications while a plugin has focus r=m_kato

https://hg.mozilla.org/integration/mozilla-inbound/rev/26b4afb254c21a417736ed9215a406eaa4cecf5e
Bug 1211352 part.4 PuppetWidget::GetIMEUpdatePreference() should request only position change notifications while a plugin has focus r=m_kato

https://hg.mozilla.org/integration/mozilla-inbound/rev/4381d0272963eefc9fc7667895809e5956401d41
Bug 1211352 part.5 PuppetWidget should cache only the focused editor rect information while a plugin has focus r=m_kato

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e889d9abef34
https://hg.mozilla.org/mozilla-central/rev/d6fbe14c354a
https://hg.mozilla.org/mozilla-central/rev/4724d4f02b57
https://hg.mozilla.org/mozilla-central/rev/26b4afb254c2
https://hg.mozilla.org/mozilla-central/rev/4381d0272963